[ISSUE#1818][MAS4.1.2] [Screen Reader-Debug] Screen reader is not reading the state for Expanded or collapsed control #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denscollo
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
tonyanziano
suggested changes
Sep 12, 2019
There was a problem hiding this comment.
I pulled the branch down and tested it and found an issue:
The aria-expanded attribute isn't being added to the <li> tags when they are initialized for the first time, it is only being added on a click event. This means that the screen reader won't read the expanded / collapsed states until after they are expanded or collapsed for the first time via mouse / keyboard.
Before clicking:
After clicking:
The tree needs to be accessible when it is rendered for the first time.
|
Thanks @tonyanziano for the feedback. We'll test it again and fix it! |
|
@tonyanziano we finished applying the changes. Now it's ready for review! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1818
Description
With this PR we enabled the screen reader to identify when the elements of the JSON viewer extension are
expandedandcollapsed.Changes made
Since the screen reader wasn't reading the
aria-expandedproperty from theultags, we added that property to the parentli