[#1846] Fixed functionality and a11y issues with generic service editor dialog. #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
corinagum
approved these changes
Sep 17, 2019
| @@ -73,3 +73,20 @@ ul.kv-pair-container { | |||
| .no-border { | |||
| border: none; | |||
| } | |||
|
|
|||
| .link-button { | |||
There was a problem hiding this comment.
just FYI I'll replace this with <LinkButton> when it's time to merge my PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1846
===
The
<KvPair/>component was actually broken and did not work. Additionally, the accessibility was not satisfactory.Before, the control would try to auto-add new rows as you started filling in the previous rows, but did not work properly. The new, simplified approach provides buttons to add or remove rows.
The component will now also focus the newest row after adding a row, as well as announce to the screen reader when the user deletes a row.
Before:
After:
