Bumped react & react-dom to 16.8.6 #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
tonyanziano
commented
Oct 23, 2019
| import 'base64url'; | ||
| import 'botframework-config/lib/models'; | ||
| import 'botframework-config/lib/schema'; | ||
| import 'botframework-webchat'; | ||
| import 'react'; | ||
| import 'react-dom'; | ||
| import 'redux'; | ||
| import 'redux-promise-middleware'; |
There was a problem hiding this comment.
this was removed as a dependency in #1721 (line where it was removed)
corinagum
previously approved these changes
Oct 23, 2019
|
A couple of tests blew up. Going to fix those. |
|
Need to fix a few components that were relying on (unknowingly) broken |
tonyanziano
force-pushed
the
toanzian/react-bump
branch
2 times, most recently
from
fe16983
to
0746000
Compare
tonyanziano
force-pushed
the
toanzian/react-bump
branch
from
0746000
to
58a75cc
Compare
cwhitten
previously approved these changes
Oct 25, 2019
packages/app/client/src/ui/shell/explorer/resourceExplorer/resourceExplorer.tsx
Outdated
Show resolved
Hide resolved
tonyanziano
force-pushed
the
toanzian/react-bump
branch
from
58a75cc
to
e32f7c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for when we bump to the next version of Web Chat.
react&react-domto^16.8.6to sync with Web ChatOpenBotDialog.tsx)<AutoComplete />component (also tied toOpenBotDialog.tsx)