Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with adding a QnA KB. #2066

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Fixed an issue with adding a QnA KB. #2066

merged 2 commits into from
Jan 29, 2020

Conversation

tonyanziano
Copy link
Contributor

Fixes #1875

===

  • After signing into Azure, trying to add a QnA maker KB would cause the in-memory QnA maker service to be initialized with a blank hostname, which was causing msbot to throw and crash the app

@coveralls
Copy link

coveralls commented Jan 29, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 69.576% when pulling c20dc22 on toanzian/qnamaker into e200c7f on master.

srinaath
srinaath previously approved these changes Jan 29, 2020
View reviewed changes
packages/app/client/src/state/sagas/servicesExplorerSagas.ts Outdated Show resolved Hide resolved
@tonyanziano tonyanziano merged commit 1c5e370 into master Jan 29, 2020
@tonyanziano tonyanziano deleted the toanzian/qnamaker branch January 29, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

@tdurnford tdurnford Awaiting requested review from tdurnford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connecting to a QnA maker knowledge base button throws an error
3 participants
@tonyanziano @coveralls @srinaath