Skip to content

Commit

Permalink
Pass conversationId to DirectLineJS constructor (#1614)
Browse files Browse the repository at this point in the history
* Fixed issue #1613

Added conversationId as an argument while instantiating DirectLine. Doing this will resume the conversation history related to a particular conversationId

* Sorted the keys alphabetically in Directline js constructor
  • Loading branch information
neetudas24 authored and a-b-r-o-w-n committed Jan 22, 2019
1 parent 0dffd85 commit beabb41
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix [#1539], outgoing typing indicators are not sent and acknowledged properly, in PR [#1541](https://github.com/Microsoft/BotFramework-WebChat/pull/1541)
- `component`: Fix [#1547](https://github.com/Microsoft/BotFramework-WebChat/issues/1547). Fixed unhandled activity type should be forwarded to custom middleware, by [@compulim](https://github.com/compulim) in PR [#1569](https://github.com/Microsoft/BotFramework-WebChat/pull/1569)
- `playground`: Fix [#1610](https://github.com/Microsoft/BotFramework-WebChat/issues/1610). Fixed bot and user avatar initials not working, by [@compulim](https://github.com/compulim) in PR [#1611](https://github.com/Microsoft/BotFramework-WebChat/pull/1611)
- `bundle`: Fix [#1613](https://github.com/Microsoft/BotFramework-WebChat/issues/1613). Pass conversationId to DirectLineJS constructor, by [@neetu-das](https://github.com/neetu-das) in PR [#1614](https://github.com/Microsoft/BotFramework-WebChat/pull/1614)

### Removed
- `botAvatarImage` and `userAvatarImage` props, as they are moved inside `styleOptions`, in PR [#1486](https://github.com/Microsoft/BotFramework-WebChat/pull/1486)
Expand Down
3 changes: 2 additions & 1 deletion packages/bundle/src/createDirectLine.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { DirectLine } from 'botframework-directlinejs';

export default function ({ domain, fetch, secret, token, webSocket }) {
export default function ({conversationId, domain, fetch, secret, token, webSocket}) {
return new DirectLine({
conversationId,
domain,
fetch,
secret,
Expand Down

0 comments on commit beabb41

Please sign in to comment.