BasicTranscript: improve focus display (#5145)

* BasicTranscript: improve focus display * Update test snapshots * Improve * Add entry --------- Co-authored-by: William Wong <[email protected]>
microsoft · Apr 25, 2024 · edca85d · edca85d
1 parent d9e4f4d
commit edca85d
Show file tree

Hide file tree

Showing 12 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -60,6 +60,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 -  Fixes [#5050](https://github.com/microsoft/BotFramework-WebChat/issues/5050). Fixed focus should not blur briefly after tapping on a suggested action, by [@compulim](https://github.com/compulim), in PR [#5097](https://github.com/microsoft/BotFramework-WebChat/issues/pull/5097)
 -  Fixes [#5111](https://github.com/microsoft/BotFramework-WebChat/issues/5111). Fixed keyboard help screen to use HTML description list, by [@compulim](https://github.com/compulim), in PR [#5116](https://github.com/microsoft/BotFramework-WebChat/issues/pull/5116)
 -  Fixes [#5080](https://github.com/microsoft/BotFramework-WebChat/issues/5080). Fixed `dateToLocaleISOString` for handling sub-hour, by [@marclundgren](https://github.com/marclundgren), in PR [#5114](https://github.com/microsoft/BotFramework-WebChat/pull/5114)
+-  Fixes [#5146](https://github.com/microsoft/BotFramework-WebChat/issues/5146). Fixed chat history focus indicator should not show up on tap, by [@OEvgeny](https://github.com/OEvgeny), in PR [#5145](https://github.com/microsoft/BotFramework-WebChat/pull/5145)
 
 ### Changed
 

diff --git a/...eyboard-help-screen-should-not-interfere-when-clicking-on-activities-4-snap.png b/...eyboard-help-screen-should-not-interfere-when-clicking-on-activities-4-snap.png
diff --git a/...-button-customization-js-scroll-to-end-button-should-be-customizable-3-snap.png b/...-button-customization-js-scroll-to-end-button-should-be-customizable-3-snap.png
diff --git a/...-button-customization-js-scroll-to-end-button-should-be-customizable-4-snap.png b/...-button-customization-js-scroll-to-end-button-should-be-customizable-4-snap.png
diff --git a/...ton-visibility-js-scroll-to-end-button-should-show-and-hide-properly-3-snap.png b/...ton-visibility-js-scroll-to-end-button-should-show-and-hide-properly-3-snap.png
diff --git a/...ton-visibility-js-scroll-to-end-button-should-show-and-hide-properly-4-snap.png b/...ton-visibility-js-scroll-to-end-button-should-show-and-hide-properly-4-snap.png
diff --git a/...ity-by-click-js-transcript-navigation-should-focus-activity-by-click-1-snap.png b/...ity-by-click-js-transcript-navigation-should-focus-activity-by-click-1-snap.png
diff --git a/...ity-by-click-js-transcript-navigation-should-focus-activity-by-click-2-snap.png b/...ity-by-click-js-transcript-navigation-should-focus-activity-by-click-2-snap.png
diff --git a/...-js-transcript-navigation-should-not-scroll-into-view-after-clicking-1-snap.png b/...-js-transcript-navigation-should-not-scroll-into-view-after-clicking-1-snap.png
diff --git a/...-js-transcript-navigation-should-not-scroll-into-view-after-clicking-3-snap.png b/...-js-transcript-navigation-should-not-scroll-into-view-after-clicking-3-snap.png
diff --git a/...-transcript-using-mouse-should-not-scroll-focused-activity-into-view-3-snap.png b/...-transcript-using-mouse-should-not-scroll-focused-activity-into-view-3-snap.png
diff --git a/packages/component/src/Styles/StyleSet/BasicTranscript.ts b/packages/component/src/Styles/StyleSet/BasicTranscript.ts
@@ -39,7 +39,7 @@ export default function createBasicTranscriptStyleSet({
         }
       },
 
-      '&:focus .webchat__basic-transcript__focus-indicator, .webchat__basic-transcript__terminator:focus + .webchat__basic-transcript__focus-indicator':
+      '&:focus-visible .webchat__basic-transcript__focus-indicator, .webchat__basic-transcript__terminator:focus-visible + .webchat__basic-transcript__focus-indicator':
         {
           height: '100%',
           borderColor: transcriptVisualKeyboardIndicatorColor,