Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need offline UI: On JavaScript Error #1525

Closed
3 tasks
corinagum opened this issue Dec 20, 2018 · 0 comments · Fixed by #1927
Closed
3 tasks

Need offline UI: On JavaScript Error #1525

corinagum opened this issue Dec 20, 2018 · 0 comments · Fixed by #1927
Assignees
@corinagum
Labels
front-burner p3

Comments

@corinagum
Copy link
Contributor

Original issue is #135, which has been split into multiple issues.

We need UI specs and implementation for:

  • When a JavaScript error is detected and Web Chat has shut itself down. Currently, you will only know this has happened by checking the console.

What we need

  • Design specs
  • Acceptance criteria
  • T-shirt sizing
@corinagum corinagum added needs-design-input UX/UI design item front-burner 4.3 p3 needs-repro Waiting for repro or investigation labels Dec 20, 2018
@compulim compulim changed the title Need Offline UI: On JavaScript Error Need offline UI: On JavaScript Error Dec 22, 2018
@compulim compulim assigned DesignPolice and unassigned DesignPolice Jan 8, 2019
@cwhitten cwhitten added 4.4 and removed 4.3 labels Jan 28, 2019
@corinagum corinagum assigned corinagum and unassigned mewa1024 and DesignPolice Apr 1, 2019
@corinagum corinagum added Approved and removed needs-design-input UX/UI design item needs-repro Waiting for repro or investigation labels Apr 1, 2019
@corinagum corinagum mentioned this issue Apr 25, 2019
Merged
cwhitten pushed a commit that referenced this issue Apr 29, 2019
@cwhitten
#1525 Add "Render error" connectivity status for JavaScript errors. (#…
0001b8e 
…1927)

* Update documentation

* Add new offlineUI component: Render error

* Modify/add offlineUI tests

* semicolon clean up

* Update CHANGELOG.md

* Fix test

* Spacing fix

* Use lolex

* Add store middleware option

* Typo

* Use page object to send message

* Reliability

* Reliability

* Update offlineUI tests with lolex mock clock

* Capitalization fix

* Fix failing tests

* Fix tests

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
front-burner p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1525 Add "Render error" connectivity status for JavaScript errors. corinagum/BotFramework-WebChat
4 participants
@cwhitten @corinagum @mewa1024 @DesignPolice