-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll Issue on Firefox #1697
Comments
Hi @dalvirsaini, looking at your screencaps, it looks like the issue you are reporting is the lack of scrollbar in the second one. Is this correct? I tested our Mock Bot on Firefox (v65) just now and didn't see the same issue. I have a few questions, if anyone who is repro-ing this issue could add their information that would be great.
|
Hi @corinagum , I am facing a scrolling issue. where i try to scroll up, it is not letting me and automatically scrolling at the bottom of the chat. Yes, it occurs on Mock Bot as well https://microsoft.github.io/BotFramework-WebChat/06.a.cognitive-services-bing-speech-js/ I'm using master/webchat-es5.js |
@compulim I don't have a touch screen laptop, could you investigate this? |
I am also seeing this issue, with Chrome, with MockBot, using this: https://microsoft.github.io/BotFramework-WebChat/06.a.cognitive-services-bing-speech-js/ See vid: https://1drv.ms/u/s!AqLTBxPBk_dXhux7ksIgD45D6LDu-g Not touch screen. I am also seeing the issue in my customised WebChat.
Is there some dependency I should revert to avoid this? |
Thanks @nicholasamiller for posting the video |
@nicholasamiller Thank you very much! Let me look into this and get back to you guys. |
Looking into this too. The bug looks very legit. But I am struggling trying to repro. Trying combination of a few things:
Will be great if someone can give me some tips. FYI, technically, the scroll component look at "onScroll" event. If it see an "onScroll" event, it will stop "sticky to bottom". In this mode, it will wait for 100ms and check if it is at the bottom. If yes, it will stick to bottom, otherwise, it will check again after 100ms. |
I kind of understand the problem. Technically speaking:
We prefer this behavior because we allow the content to be expanded, without using any hints from HTML DOM. We tried alternative approach in 4.2, which we explicitly tell the scrollable panel we have expanded, but the UX doesn't go well (sometimes Web Chat don't scroll to bottom). When the user scroll to top, the following things will happen:
For every 150ms, we check if we are at the bottom. If no and we are sticky, we will scroll to bottom. But in Firefox, the check is being inserted between 1 and 2. That means, the check will see "I am not at the bottom, but I am still sticky, I need to scroll to bottom." Thus, we are seeing this behavior. |
Also in Chrome - see my vid.
…On Wed., 13 Feb. 2019, 11:46 William Wong ***@***.*** wrote:
I kind of understand the problem.
Technically speaking:
- "scroll to bottom" means, "if I am sticky, and I am not at the
bottom, scroll to bottom"
- "I am no longer sticky" means,
- "scroll event emitted due to user gesture, and the scrollTop
value is no longer at bottom"
- "I become sticky" means,
- "scroll event emitted, scrollTop value changed to the bottom
value"
We prefer this behavior because we allow the content to be expanded,
without using any hints from HTML DOM. We tried alternative approach in
4.2, which we explicitly tell the scrollable panel we have expanded, but
the UX doesn't go well (sometimes Web Chat don't scroll to bottom).
When the user scroll to top, the following things will happen:
1. scrollTop set to 0
2. Fire scroll event
For every 150ms, we check if we are at the bottom. If no and we are
sticky, we will scroll to bottom.
But in Firefox, the check is being inserted between 1 and 2. That means,
the check will see "I am not at the bottom, but I am still sticky, I need
to scroll to bottom." Thus, we are seeing this behavior.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1697 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATrTcA5VdaBzIBpIqg0qA9zqqc4YmoCPks5vM2BXgaJpZM4ai_bt>
.
|
Need some community help here because I cannot reliably repro on my box (repro chance = 1-in-50). I don't know if my fix really works or not. @dalvirsaini @keshavnagpal @nicholasamiller could you guys help me by trying out the following pages?
After you land on the page, type help and it should have enough content that requires scrolling. Many thanks! |
@compulim I went ahead and copied your webchat.js file and used in my solution, it fixed the issue I need to use webchat-es5.js Thanks |
I am facing scroll issue on Firefox and mobile. here i shared screen shot of chrome and Firefox. for chrome its fine but for Firefox its not working.
Here is example of Chrome. here scroll is working:
Here is Example of Firefox where scroll not working
Thanks
The text was updated successfully, but these errors were encountered: