Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL: Padding around typing indicator #2902

Closed
compulim opened this issue Feb 13, 2020 · 0 comments · Fixed by #2890
Closed

RTL: Padding around typing indicator #2902

compulim opened this issue Feb 13, 2020 · 0 comments · Fixed by #2890
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Screenshots

image

Version

corinagum/1976-RTL

Describe the bug

Typing indicator on RTL is not padded correctly.

Steps to reproduce

  1. Open Web Chat in RTL mode
  2. Type typing to MockBot

Expected behavior

This is LTR.

image

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Feb 13, 2020
@corinagum corinagum mentioned this issue Feb 13, 2020
Merged
52 tasks
corinagum pushed a commit to corinagum/BotFramework-WebChat that referenced this issue Feb 14, 2020
Fix microsoft#2902
f058d61
corinagum added a commit that referenced this issue Feb 14, 2020
@corinagum @compulim
Add RTL support (#2890)
7415e74 
* Add Hebrew to list of languages

* Minor styling adjustments to playground

* Update Basic Web Chat to function component

* move prettier-readmes into lint-staged

* Add getRTLList.js to fetch RTL languages

* update package.jsono

* Determine direction based off language if dir='auto'

* Support manually setting direction in playground

* Add margins to both side of components, ex spinner, for RTL

* Deprecate spinnerAnimationPaddingRight in favor of spinnerAnimationPadding

* Fix CHANGELOG rebase error

* Refactor useDirection

* Suggested actions RTL

* Fix SpinnerAnimation styling for rtl and ltr

* tranform SendIcon and TypingAnimation based on dir

* Update LOCALIZATION file

* Update playground App.js with ar-JO

* Add ar-JO to localization with rtl support

* Add rtl languages to embed locale

* Add rtl support for Carousel

* Add rtl support for bubble nub

* Add rtl support to Scroll to end button

* Fix carousel film strip timestamp in rtl

* Add useDirection documentation to HOOKS.md

* md file cleanup

* Refactor fixes

* RTL support for icons

* Refactor RTL support in Bubble.js

* Refactor RTL support in carousel

* Refactor RTL for stacked and error

* Refactor other components for RTL

* Add unofficial Adaptive Card RTL support

* Add RTL to FileContent component

* File cleanup

* Restore change-locale sample & create change-locale-direction

* Carousel padding fix & readme cleanup

* Linting fixes

* Update CHANGELOG & documentation

* Fix linting errors

* New RTL tests

* Add retaken screenshots

* Remove echos from tableflip command

* Add more rtl tests

* Fix #2903

* Fix #2902

* Apply suggestions from code review

Co-Authored-By: William Wong <[email protected]>

* Comment cleanup

* Update packages/component/src/Styles/StyleSet/SpinnerAnimation.js

Co-Authored-By: William Wong <[email protected]>

Co-authored-by: William Wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RTL support corinagum/BotFramework-WebChat
2 participants
@compulim @corinagum