Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] New messages button are not read when focus on it #3203

Closed
compulim opened this issue Jun 4, 2020 · 0 comments · Fixed by #3204
Closed

[Accessibility] New messages button are not read when focus on it #3203

compulim opened this issue Jun 4, 2020 · 0 comments · Fixed by #3204
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Jun 4, 2020

Version

master

Describe the bug

When we TAB on the "New messages" button, no content is read.

This is because the button parent has role="separator", and it is has a special flag called "presentational children". That means, all descendants will have role="presentation" automatically assigned to it and cannot be overridden.

We need to turn the separator into a button instead. This is supported as long as we provide all required interactions.

Steps to reproduce

  1. Type proactive card
  2. Immediately type help, scroll up a bit
  3. Wait for the "New messages" button to show up
  4. Press TAB to focus on the "New messages" button

Expected behavior

AT will read "New messages button" or similar phrases.

Instead, AT speak nothing.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. area-accessibility labels Jun 4, 2020
@compulim compulim self-assigned this Jun 4, 2020
@compulim compulim mentioned this issue Jun 10, 2020
38 tasks
@compulim compulim added the R10 label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant