You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do not merge any other unrelated changes after this PR. Any other PR merged, will need to be re-tested
Run daily pipeline manually, set "generate release version number" to true
(This will not push to NPM or CDN)
The build number is 136995 and commit is 69d0afb
Test
The test should run against the build artifacts from Azure Pipelines.
Manual testing on major browsers using webchat-release-testing
Chrome 83.0.4103.97
Edge (Anaheim) 83.0.478.45
Edge (UWP) 44.19041.1.0
Firefox 77.0.1
IE11
macOS Safari 13.0.3 (15608.3.10.1.4)
DLSpeech: Web Socket connection to westus2.convai.speech.microsoft.com closed instantly after connected, it also repro on previous versions of Web Chat (failed on 4.9.0, 4.8.1)
As it also repro on 4.9.0 and 4.8.1, I think this is service-side issue
iOS Safari 13.4.1
Android Chrome 83.0.4103.96
Test specific fixes related to 4.9.1 and previous releases
(Look at CHANGELOG.md and list out PRs that were not covered with automated tests)
Release
Make sure you are on masteror qfe branch, run git status to check
git pull
Verify /package.json, /package-lock.json, and CHANGELOG.md has a version of 4.9.1
git log
Verify the latest commit is 69d0afb
git tag v4.9.1
git push -u upstream v4.9.1
You do not need to kick off a build again, use the previous build
Create a new GitHub release, copy entries from CHANGELOG.md
Affecting Adaptive Cards, legacy cards and suggested actions
For openUrl card action, we are now whitelisting the URL scheme using the same whitelist from the default Markdown + sanitize engine, which includes data, http, https, ftp, mailto, sip, and tel
To whitelist a different set of URL schemes, please implement the card action middleware to override this behavior
Added
Resolves #3205. Added Direct Line App Service Extension protocol, by @compulim in PR #3206
Resolves #3225. Support allowed scheme with openUrl card action, by @compulim in PR #3226
Fixed
Fixes #1340. Card container should not be focusable if they do not have tapAction, by @compulim in PR #3193
Fixed #3196. Cards with tapAction should be executable by ENTER or SPACEBAR key, by @compulim in PR #3197
Fixed #3203. "New messages" button should be narrated by assistive technology, by @compulim in PR #3204
Fixed #3217. Make sure rel="noopener noreferrer is not sanitized, by @compulim in PR #3220
Fixed #3223. Tap an openUrl card action should open URL in a new tab with noopener noreferrer set, by @compulim in PR #3224
Changed
Bumped Adaptive Cards dependencies, by @compulim in PR #3193
Checklist
Build
https://botbuilder.myget.org/feed/botbuilder-v4-js-daily/package/npm/botbuilderCHANGELOG.md
to mark specific changes in4.9.1
npm version --no-git-tag-version 4.9.1
master
, the PR number is [HIGH] Bump to production 4.9.1 #323169d0afb
true
136995
and commit is69d0afb
Test
webchat-release-testing
westus2.convai.speech.microsoft.com
closed instantly after connected, it also repro on previous versions of Web Chat (failed on 4.9.0, 4.8.1)4.9.1
and previous releasesCHANGELOG.md
and list out PRs that were not covered with automated tests)Release
master
orbranch, runqfe
git status
to checkgit pull
/package.json
,/package-lock.json
, andCHANGELOG.md
has a version of4.9.1
git log
69d0afb
git tag v4.9.1
git push -u upstream v4.9.1
CHANGELOG.md
curl -H 'Accept-Encoding: gzip' https://cdn.botframework.com/botframework-webchat/4.9.1/webchat.js | gunzip - | openssl dgst -sha384 -binary | openssl base64 -A
cat webchat.js | openssl dgst -sha384 -binary | openssl base64 -A
stats.json
and 4 tarballswebchat-release-testing/drops
136995
, release number is2268
and commit is69d0afb
136995
, release number is2269
and commit is69d0afb
131156
Post-release check
webchat-release-testing
01.create-react-app
01.create-react-app/node_modules
npm install [email protected]
(just install the bundle package)Notification to interesting parties
Changelog
[4.9.1] - 2020-06-09
Breaking changes
openUrl
card action, we are now whitelisting the URL scheme using the same whitelist from the default Markdown + sanitize engine, which includesdata
,http
,https
,ftp
,mailto
,sip
, andtel
Added
openUrl
card action, by @compulim in PR #3226Fixed
tapAction
, by @compulim in PR #3193tapAction
should be executable by ENTER or SPACEBAR key, by @compulim in PR #3197rel="noopener noreferrer
is not sanitized, by @compulim in PR #3220openUrl
card action should open URL in a new tab withnoopener noreferrer
set, by @compulim in PR #3224Changed
[email protected]
@babel/[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
et-EE
), by @LiweiMa in PR #3183[email protected]
, by @compulim in PR #3206Samples
The text was updated successfully, but these errors were encountered: