Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Markdown] The link should have rel="noopener noreferrer" #3217

Closed
compulim opened this issue Jun 8, 2020 · 0 comments · Fixed by #3220
Closed

[Markdown] The link should have rel="noopener noreferrer" #3217

compulim opened this issue Jun 8, 2020 · 0 comments · Fixed by #3220
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Jun 8, 2020

Screenshots

image

Version

master

Describe the bug

In our Markdown engine, we added rel="noopener noreferrer", but it is not showing up in HTML.

image

Steps to reproduce

  1. echo [Hello, World!](https://bing.com) to MockBot
  2. Verify the <a> element

Expected behavior

The echoed <a> should have rel="noopener noreferrer"

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. R10 labels Jun 8, 2020
@compulim compulim self-assigned this Jun 8, 2020
@compulim compulim mentioned this issue Jun 8, 2020
Merged
1 task
@compulim compulim mentioned this issue Jun 10, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Markdown: whitelist "rel" attribute on sanitization compulim/BotFramework-WebChat
1 participant
@compulim