Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue : Ensure aria-roledescription is only used on elements with an implicit or explicit role #3537

Closed
Varshazz opened this issue Oct 13, 2020 · 4 comments · Fixed by #3551, #3583, #3587 or #3599
Closed

Accessibility issue : Ensure aria-roledescription is only used on elements with an implicit or explicit role #3537

Varshazz opened this issue Oct 13, 2020 · 4 comments · Fixed by #3551, #3583, #3587 or #3599
Assignees
@corinagum
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker
Milestone
R12

Comments

@Varshazz
Copy link

Varshazz commented Oct 13, 2020 •
edited by corinagum
Loading

[edit by @corinagum 11/9/2020]

See latest comment: I have reopened this bug due to 'layout double' and 'layout carousel' still showing as breaking accessibility in Accessibility Insights.

/end edit

Running a fast pass on WebChat bot, getting this error

Path | #webchat__stacked-layout__id--i5ta9

**Fix the following:Give the element a role that supports aria-roledescription**

Similarly on all these:

Path | #webchat__stacked-layout__id--wpsrv
#webchat__stacked-layout__id--y6f93
#webchat__stacked-layout__id--vsynk

image
@corinagum
Copy link
Contributor

@Varshazz could you add the screencaps from the email chain? Thanks.

@corinagum corinagum added area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. needs-team-attention labels Oct 13, 2020
@Varshazz
Copy link
Author

Done. Some of the text is smudged, please ignore that.

@corinagum
Copy link
Contributor

Adding this to team discussion for scheduling.

@corinagum corinagum added this to the R11 milestone Oct 14, 2020
@cwhitten cwhitten added the p0 Must Fix. Release-blocker label Oct 14, 2020
@corinagum corinagum assigned corinagum and unassigned compulim Oct 19, 2020
@corinagum corinagum mentioned this issue Oct 20, 2020
Merged
11 tasks
@compulim compulim mentioned this issue Oct 29, 2020
Closed
48 tasks
This was referenced Nov 3, 2020
Merged
Merged
Closed
@corinagum
Copy link
Contributor

Reopening issue -- unfortunately the Mock Bot commands 'layout double' and 'layout carousel' are still not showing the activities with implicit/explicit role.

@corinagum corinagum reopened this Nov 10, 2020
@corinagum corinagum removed this from the R11 milestone Nov 10, 2020
@corinagum corinagum added this to the R12 milestone Nov 10, 2020
@corinagum corinagum mentioned this issue Nov 10, 2020
Merged
11 tasks
@compulim compulim mentioned this issue Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker
Projects
None yet
Milestone
R12
4 participants
@cwhitten @compulim @corinagum @Varshazz