Add more error handling to mountAdaptiveCards #1176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2018 19:15
compulim
reviewed
Sep 28, 2018
| adaptiveCard.parse(cardWithoutHttpActions(this.props.jsonCard)); | ||
| errors = adaptiveCard.validate(); | ||
| } catch (error) { | ||
| errors.push(error); |
There was a problem hiding this comment.
Can you verify how errors array get displayed on the screen?
Think about the upstream and downstream when changing the code:
- Downstream
- Can the screen display
Error? - Can it display
IValidationErrorandErrorat the same time? - What's the code over there? There is a command at MockBot v4 to force
IValidationError, The command is calledcard brokenandcard broken:1 - Also add a case to MockBot to make sure we capture this regression later
- MockBot might already have this captured or not, I am not quite sure
- Can the screen display
- Upstream: there is no upstreamer in this case, so it's good
Also, try it in v4 by visiting https://webchat-playground.azure-websites.net/. If there is a bug over there, file another issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1125
@compulim could you let me know if this is what you were looking for for this fix? (also could you provide guidance on appropriate tests?)