Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with string interpolation #1509

Merged
merged 8 commits into from
Dec 21, 2018
Merged

Fix error with string interpolation #1509

merged 8 commits into from
Dec 21, 2018

Conversation

odysseus1973
Copy link
Contributor

No description provided.

compulim
compulim requested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update CHANGELOG.md to include this PR?

@odysseus1973
Add fallback for browsers without Intl support
0050b1e 
Not sure if it's right, since I don't have a browser without Intl support
@odysseus1973
Merge branch 'master' into master
962e582
@coveralls
Copy link

coveralls commented Dec 19, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 647

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 44.902%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Localization/ru-RU.js 0 5 0.0%
Totals Coverage Status
Change from base Build 638: -0.08%
Covered Lines: 726
Relevant Lines: 1443
💛 - Coveralls

@compulim
Copy link
Contributor

👍 (Waiting for Travis CI to complete and will merge)

Thanks. I didn't realize we didn't handle peaceful fallback of window.Intl in en-US, we will add it on en-US.

@corinagum corinagum mentioned this pull request Dec 21, 2018
Closed
@compulim compulim merged commit 833ef75 into microsoft:master Dec 21, 2018
@compulim
Copy link
Contributor

It's in, should be start popping up >= @4.2.1-master.833ef75. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odysseus1973 @coveralls @compulim