Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Allow ponyfilling window.open #1604

Closed
wants to merge 1 commit into from
Closed

[DRAFT] Allow ponyfilling window.open #1604

wants to merge 1 commit into from

Conversation

justinwilaby
Copy link

@justinwilaby justinwilaby commented Jan 17, 2019 •
edited by compulim
Loading

Fix #368.

justinwilaby
justinwilaby commented Jan 17, 2019
View reviewed changes
packages/component/src/Composer.js
// TODO: [P3] We should support ponyfill for window.open
// This is as-of v3
window.open(value);
const factory = this.props.externalUrlHandlerFactory({ value });
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compulim - Let me know what you think should be included in the factory's function signature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?

windowOpenPonyfillFactory({ activity, attachment, cardAction }) => (url: string, windowName: string, windowFeatures: string) => void

For the object returned from the ponyfill, we can assume we are not acting on it, until we need it. So I am leaving it void right now.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 778

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 48.363%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/BasicWebChat.js 0 1 0.0%
packages/component/src/Composer.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Composer.js 1 65.67%
Totals Coverage Status
Change from base Build 776: 0.4%
Covered Lines: 793
Relevant Lines: 1477
💛 - Coveralls

@compulim compulim changed the title [wip] #368 - initial props structure [DRAFT] Allow ponyfilling window.open Jan 23, 2019
@cwhitten
Copy link
Member

cwhitten commented Feb 6, 2019

@compulim @justinwilaby where are we at on this?

@compulim
Copy link
Contributor

compulim commented Feb 6, 2019

Will fix in #1704. Closing this for now.

@compulim compulim closed this Feb 6, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix/#368-window-open branch February 6, 2019 22:16
@justinwilaby justinwilaby mentioned this pull request Jun 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinwilaby @coveralls @cwhitten @compulim