Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use random user ID if not specified #1612

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Use random user ID if not specified #1612

merged 1 commit into from
Jan 18, 2019

Conversation

compulim
Copy link
Contributor

Fix #1344.

Background

Instead of using default-user, use a random user ID if not specified. Will try to use RNG if the environment support.

Changelog

@coveralls
Copy link

Pull Request Test Coverage Report for Build 786

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 47.865%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/sagas/connectSaga.js 0 4 0.0%
Totals Coverage Status
Change from base Build 782: 0.4%
Covered Lines: 783
Relevant Lines: 1475
💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n merged commit ceab1f8 into microsoft:master Jan 18, 2019
@cwhitten cwhitten added 4.3 p0 Must Fix. Release-blocker labels Jan 18, 2019
@darrenj darrenj mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
p0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compulim @coveralls @cwhitten @corinagum @a-b-r-o-w-n