Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WEB_CHAT/SEND_EVENT for minimizable Web Chat sample #1631

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

compulim
Copy link
Contributor

Fix #1619.

Updated to use WEB_CHAT/SEND_EVENT for minimizable Web Chat sample, instead of using DIRECT_LINE/POST_ACTIVITY, which is a low-level action.

Changelog

Samples

@corinagum
Copy link
Contributor

were you planning on updating the speech button sample at the same time? Or should I file a different issue?

@compulim
Copy link
Contributor Author

      were you planning on updating the speech button sample at the same time? Or should I file a different issue?

Different issue. I was thinking the same too. :)

@coveralls
Copy link

coveralls commented Jan 23, 2019

Pull Request Test Coverage Report for Build 823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 47.558%

Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 822: -0.2%
Covered Lines: 792
Relevant Lines: 1503

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants