Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username to activity for parity with v3 #1682

Merged
merged 5 commits into from
Feb 5, 2019
Merged

Add username to activity for parity with v3 #1682

merged 5 commits into from
Feb 5, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 1, 2019 •
edited
Loading

Fix #1321.

Changelog

Added

@compulim compulim added the parity The issue describes a gap in parity between two or more platforms. label Feb 1, 2019
@coveralls
Copy link

coveralls commented Feb 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 953

  • 10 of 11 (90.91%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 53.251%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Composer.js 3 4 75.0%
Totals Coverage Status
Change from base Build 952: 0.1%
Covered Lines: 915
Relevant Lines: 1564
💛 - Coveralls

@compulim compulim merged commit 0b60abf into microsoft:master Feb 5, 2019
@compulim compulim deleted the parity-username branch February 5, 2019 20:21
@compulim compulim mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set the user name in from in new version
3 participants
@compulim @coveralls @cwhitten