Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added customizable height and width style options to root. #1702

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Added customizable height and width style options to root. #1702

merged 1 commit into from
Feb 6, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Feb 6, 2019 •
edited
Loading

Fix for #1267

===

This adds customizable rootHeight & rootWidth styleset options to the root style set.

Images of working sample: (background element is pink)

50% height / width

image

100% height / 75% width

image

image

@corinagum
Copy link
Contributor

PSA to anyone looking to alter this feature in their implementation of Web Chat: please take a look at our branding sample on how to change default styles.

@coveralls
Copy link

coveralls commented Feb 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 976

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 53.173%
Totals Coverage Status
Change from base Build 969: 0.08%
Covered Lines: 914
Relevant Lines: 1564
💛 - Coveralls

@tonyanziano
Copy link
Contributor Author

I'll add a changelog entry and rebase upon approval.

a-b-r-o-w-n
a-b-r-o-w-n requested changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update the changelog!

@tonyanziano tonyanziano merged commit c63e9c9 into master Feb 6, 2019
@tonyanziano tonyanziano deleted the toanzian/100%-webchat branch February 6, 2019 21:37
@tonyanziano tonyanziano mentioned this pull request Feb 6, 2019
Closed
@corinagum corinagum mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@corinagum corinagum corinagum approved these changes

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyanziano @corinagum @coveralls @a-b-r-o-w-n