Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS collisions with Bootstrap and bump memoize-one #1884

Merged
merged 4 commits into from
Apr 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix [#1768](https://github.com/Microsoft/BotFramework-WebChat/issues/1768). Add style option to modify all Send Box borders, by [@corinagum](https://github.com/corinagum) in PR [#1871](https://github.com/Microsoft/BotFramework-WebChat/pull/1871)
- Fix [#1827](https://github.com/Microsoft/BotFramework-WebChat/issues/1827). Remove renderer for unknown activities, by [@corinagum](https://github.com/corinagum) in PR [#1873](https://github.com/Microsoft/BotFramework-WebChat/pull/1873)
- Fix [#1586](https://github.com/Microsoft/BotFramework-WebChat/issues/1586). Fix theming of suggested actions buttons, by [@corinagum](https://github.com/corinagum) in PR [#1883](https://github.com/Microsoft/BotFramework-WebChat/pull/1883)
- Fix [#1837](https://github.com/Microsoft/BotFramework-WebChat/issues/1837), [#1643](https://github.com/Microsoft/BotFramework-WebChat/issues/1643). Fix style conflicts with bootstrap and bump `memoize-one`, by [@corinagum](https://github.com/corinagum) in PR [#1884](https://github.com/Microsoft/BotFramework-WebChat/pull/1884)

## [4.3.0] - 2019-03-04

Expand Down
13 changes: 10 additions & 3 deletions packages/bundle/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/bundle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"core-js": "^2.5.7",
"markdown-it": "^8.4.2",
"markdown-it-for-inline": "^0.1.1",
"memoize-one": "^4.0.2",
"memoize-one": "^5.0.2",
"microsoft-speech-browser-sdk": "^0.0.12",
"react": "^16.5.0",
"react-dom": "^16.5.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/component/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/component/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"bytes": "^3.0.0",
"classnames": "^2.2.6",
"glamor": "^2.20.40",
"memoize-one": "^3.1.1",
"memoize-one": "^5.0.2",
"react-dictate-button": "^1.1.3",
"react-film": "~1.1.2",
"react-redux": "^5.0.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/component/src/Activity/CarouselFilmStrip.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ const ConnectedCarouselFilmStrip = connectCarouselFilmStrip(
</ul>
<div
aria-hidden={ true }
className="row"
className="webchat__row"
>
{(
activity.channelData
Expand Down
12 changes: 6 additions & 6 deletions packages/component/src/Activity/StackedLayout.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const ROOT_CSS = css({
flexGrow: 1,
overflow: 'hidden',

'& > .row': {
'& > .webchat__row': {
display: 'flex',

'& > .bubble, & > .timestamp': {
Expand All @@ -47,7 +47,7 @@ const ROOT_CSS = css({
'&.from-user': {
flexDirection: 'row-reverse',

'& > .content > .row': {
'& > .content > .webchat__row': {
flexDirection: 'row-reverse'
}
}
Expand Down Expand Up @@ -119,7 +119,7 @@ export default connectStackedLayout(
<div className="content">
{
activity.type === 'typing' ?
<div className="row typing">
<div className="webchat__row typing">
{
children({
activity,
Expand All @@ -129,7 +129,7 @@ export default connectStackedLayout(
<div className="filler" />
</div>
: !!activityDisplayText &&
<div className="row message">
<div className="webchat__row message">
<Bubble
aria-label={ ariaLabel }
className="bubble"
Expand All @@ -150,7 +150,7 @@ export default connectStackedLayout(
}
{
(activity.attachments || []).map((attachment, index) =>
<div className="row attachment" key={ index }>
<div className="webchat__row attachment" key={ index }>
<Bubble
className="attachment bubble"
fromUser={ fromUser }
Expand All @@ -163,7 +163,7 @@ export default connectStackedLayout(
}
<div
aria-hidden={ true }
className="row"
className="webchat__row"
>
{ showSendStatus ?
<SendStatus activity={ activity } className="timestamp" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default function ({
}
},

'& > .row': {
'& > .webchat__row': {
marginLeft: paddingRegular
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/component/src/Styles/StyleSet/StackedLayout.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function ({
marginRight: paddingRegular,

'& > .content': {
'& > .row': {
'& > .webchat__row': {
'& > .bubble, & > .timestamp': {
maxWidth: bubbleMaxWidth
},
Expand Down
18 changes: 15 additions & 3 deletions packages/playground/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"glamor": "^2.20.40",
"markdown-it": "^8.4.1",
"markdown-it-for-inline": "^0.1.1",
"memoize-one": "^4.0.2",
"memoize-one": "^5.0.2",
"microsoft-speech-browser-sdk": "^0.0.12",
"on-error-resume-next": "^1.0.0",
"react": "^16.4.1",
Expand Down
Loading