Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use undefined for createWebSpeechPonyfill #2009

Merged
merged 2 commits into from
May 21, 2019
Merged

Use undefined for createWebSpeechPonyfill #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afc45a6
Use undefined for createWebSpeechPonyfill
compulim May 20, 2019
340a564
Add entry
compulim May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fix [#1974](https://github.com/Microsoft/BotFramework-WebChat/issues/1974). Update `/docs/` folder to `/media/` and delete unused images, by [@corinagum](https://github.com/corinagum) in PR [#1975](https://github.com/Microsoft/BotFramework-WebChat/pull/1975)
- Fix [#1969](https://github.com/Microsoft/BotFramework-WebChat/issues/1969). Move `styleSet`s related to Adaptive Cards to full bundle, by [@corinagum](https://github.com/corinagum) in PR [#1987](https://github.com/Microsoft/BotFramework-WebChat/pull/1987)
- Fix [#1429](https://github.com/Microsoft/BotFramework-WebChat/issues/1429). Changed Markdown-it options to render newline characters correctly, by [@tdurnford](https://github.com/tdurnford) in PR [#1988](https://github.com/Microsoft/BotFramework-WebChat/pull/1988)
- Fix [#2008](https://github.com/Microsoft/BotFramework-WebChat/issues/2008). Fixed playground due to recent eslint changes, by [@compulim](https://github.com/compulim) in PR [#2009](https://github.com/Microsoft/BotFramework-WebChat/pull/2009)

## [4.4.1] - 2019-05-02

Expand Down
3 changes: 2 additions & 1 deletion packages/component/src/Dictation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,15 @@ class Dictation extends React.Component {

Dictation.defaultProps = {
disabled: false,
onError: undefined,
webSpeechPonyfill: undefined
};

Dictation.propTypes = {
dictateState: PropTypes.number.isRequired,
disabled: PropTypes.bool,
language: PropTypes.string.isRequired,
onError: PropTypes.func.isRequired,
onError: PropTypes.func,
setDictateInterims: PropTypes.func.isRequired,
setDictateState: PropTypes.func.isRequired,
setSendBox: PropTypes.func.isRequired,
Expand Down
4 changes: 2 additions & 2 deletions packages/playground/src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default class extends React.Component {
userAvatarInitials: 'WC',
userID,
username: 'Web Chat user',
webSpeechPonyfillFactory: null
webSpeechPonyfillFactory: undefined
};
}

Expand Down Expand Up @@ -263,7 +263,7 @@ export default class extends React.Component {
<ReactWebChat
activityMiddleware={ this.activityMiddleware }
attachmentMiddleware={ this.attachmentMiddleware }
className={ WEB_CHAT_CSS }
className={ WEB_CHAT_CSS + '' }
groupTimestamp={ groupTimestamp === 'default' ? undefined : groupTimestamp === 'false' ? false : +groupTimestamp }
directLine={ directLine }
disabled={ disabled }
Expand Down