Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2379.
Changelog Entry
Fixed
null
, by @compulim in PR #2408Description
To configure off speech synthesis but leaving speech recognition, we pass a Web Speech ponyfill:
We explicitly set
speechSynthesis
tonull
rather than leaving it asundefined
, becauseundefined
usually means, "implicitly leave as blank" and "leave it as default". I.e. Web Chat will use speech synthesis engine from browser if it isundefined
.But when we setting it to
null
, we are seeing exception because we are trying to synthesis using anull
engine.Specific Changes
In
BasicTranscript.js
, ifspeechSynthesis
is falsy, do not render<SpeakActivity>
, which will stop from synthesizing the text.