-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2461 Add isomorphic-react and isomorphic-react-dom packages #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
tdurnford and
tonyanziano
as code owners
October 16, 2019 17:16
corinagum
force-pushed
the
2461-isomorphic
branch
from
October 16, 2019 17:17
3e9a956
to
7da651e
Compare
corinagum
changed the title
2461 isomorphic
#2461 Add isomorphic-react and isomorphic-react-dom packages
Oct 16, 2019
compulim
previously approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
compulim
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking and peerDependencies
change.
Looks good. 😉
compulim
reviewed
Oct 18, 2019
compulim
approved these changes
Oct 18, 2019
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2472, #2461
Changelog Entry
isomorphic-react
andisomorphic-react-dom
packages, by @compulim and @corinagum, in PR #2478Description
Web Chat will now check for a global version of react, and prioritize that if detected.
Specific Changes
isomorphic-react
andisomorphic-react-dom
packages