Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2461 Add isomorphic-react and isomorphic-react-dom packages #2478

Merged
merged 16 commits into from
Oct 18, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 16, 2019

Fixes #2472, #2461

Changelog Entry

Description

Web Chat will now check for a global version of react, and prioritize that if detected.

Specific Changes

  • Created isomorphic-react and isomorphic-react-dom packages

@corinagum corinagum changed the title 2461 isomorphic #2461 Add isomorphic-react and isomorphic-react-dom packages Oct 16, 2019
compulim
compulim previously approved these changes Oct 16, 2019
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
packages/isomorphic-react-dom/package.json Show resolved Hide resolved
packages/isomorphic-react/package.json Show resolved Hide resolved
packages/isomorphic-react/webpack.config.js Outdated Show resolved Hide resolved
samples/03.a.host-with-react/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking and peerDependencies change.

Looks good. 😉

packages/bundle/package.json Outdated Show resolved Hide resolved
packages/component/package.json Outdated Show resolved Hide resolved
packages/component/src/Activity/Bubble.js Outdated Show resolved Hide resolved
packages/component/src/Activity/CarouselFilmStrip.js Outdated Show resolved Hide resolved
packages/component/src/Activity/StackedLayout.js Outdated Show resolved Hide resolved
samples/03.a.host-with-react/index.html Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 65.222% when pulling 313f787 on corinagum:2461-isomorphic into 9e85cbf on microsoft:master.

@compulim compulim merged commit 3f70e3b into microsoft:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants