Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep AudioContext object and add WILL_START dictate state #2520

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 30, 2019

Fixes #2516.
Fixes #2518.
Fixes #2519.

Changelog Entry

  • Fixes #2516. Disable microphone input for expecting input hint on Safari, by @compulim in PR #2517 and PR #2520
  • Fixes #2518. Synthesis of bot activities with input hint expecting, should be interruptible, by @compulim in PR #2520
  • Fixes #2519. On Safari, microphone should turn on after synthesis of bot activities with input hint expecting, by @compulim in PR #2520

Description

Final mile for "input hint expecting" feature.

This will fix 3 issues, regarding interruptibility and compatibility with Safari.

Specific Changes

  • Introduced a new dictate state called WILL_START
    • After synthesizing all pending activities, this dictate state will turn into STARTING, which will start the speech engine
    • This improve interruptibility of activities
  • Keep the same AudioContext object after first creation
    • AudioContext will receive blessing after the end-user consent on the privacy dialog
    • The blessed object can be used for recognition without additional user interactions (click or tap)
    • The blessed object should be kept across multiple recognition sessions

  • Testing Added
    • No tests are currently added, we will add manual steps to the release checklist

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 63.345% when pulling b9adae4 on compulim:fix-last-speech-bug into 69b4a13 on microsoft:master.

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests after build

@corinagum corinagum merged commit 8d06a54 into microsoft:master Oct 30, 2019
@compulim compulim mentioned this pull request Oct 31, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants