Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webpack-visualizer-plugin with webpack-stats-plugin #2584

Merged
merged 2 commits into from
Nov 11, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 11, 2019

Fixes #2583.

Changelog Entry

Changed

Description

(Copied from #2583.)

This bug only affect users who "npm install" Web Chat with devDependencies, e.g. playground or any packages that use npm link or lerna to include Web Chat in their build.

When botframework-webchat is installed with devDependencies, it installed React 0.14.9 due to transient dependencies from webpack-visualizer-plugin

botframework-webchat do not include devDependencies of React 16.8.6. This is because of the "Rules of Hooks" to maintain a single instance of React. We do include React 16.8.6 at the root package, so both playground and botframework-webchat-* will share the same instance of React.

Specific Changes

  • bundle: Replace webpack-visualizer-plugin plugin with webpack-stats-plugin

  • Testing Added
    • No tests are added for playground

@compulim compulim changed the title Use webpack-stats-plugin Replace webpack-visualizer-plugin with webpack-stats-plugin Nov 11, 2019
Copy link
Contributor

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim
Copy link
Contributor Author

FYI, this should be caught earlier if we have #2505. We are prophets (or things just bite us back.)

@compulim compulim merged commit 38c92b2 into microsoft:master Nov 11, 2019
@compulim compulim deleted the fix-2583 branch November 11, 2019 21:01
@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.902% when pulling 1eef614 on compulim:fix-2583 into a97fbb8 on microsoft:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground is not loading because of dependencies problem with React
4 participants