Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese translation #2631

Merged
merged 8 commits into from
Nov 25, 2019
Merged

Add Chinese translation #2631

merged 8 commits into from
Nov 25, 2019

Conversation

spyip
Copy link
Contributor

@spyip spyip commented Nov 22, 2019 •
edited
Loading

Fixes #2620

Changelog Entry

Description

Update Chinese localization files

Specific Changes

Updated:

  • zh-HANT.js
  • zh-HANS.js
  • zh-YUE.js
  • Testing Added

@corinagum
Copy link
Contributor

❤️❤️❤️

@corinagum
Copy link
Contributor

@spyip it looks like there are linting errors again, could you take a look? Thanks!

@compulim compulim changed the title Fix-2620 Add Chinese translation Nov 23, 2019
@compulim
Copy link
Contributor

Copying the test result here.

botframework-webchat-component: /home/vsts/work/1/s/packages/component/src/Localization/zh-HANS.js
botframework-webchat-component:   90:27  error  'uploadFileWithFileSize' is not defined  no-undef
botframework-webchat-component: /home/vsts/work/1/s/packages/component/src/Localization/zh-HANT.js
botframework-webchat-component:   70:29  error  'downloadFileWithFileSize' is not defined  no-undef
botframework-webchat-component:   93:27  error  'uploadFileWithFileSize' is not defined    no-undef
botframework-webchat-component: /home/vsts/work/1/s/packages/component/src/Localization/zh-YUE.js
botframework-webchat-component:   71:29  error  'downloadFileWithFileSize' is not defined  no-undef
botframework-webchat-component:   96:27  error  'uploadFileWithFileSize' is not defined    no-undef

@compulim
Copy link
Contributor

timestamp-js-update-timestamp-on-the-fly-3-diff.png

image

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 64.269% when pulling b475a90 on spyip:fix-2620 into f5fa609 on microsoft:master.

@compulim compulim merged commit 35610b9 into microsoft:master Nov 25, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Pre-release: Need Manual Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Chinese localization files
4 participants
@spyip @corinagum @compulim @coveralls