Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLSpeech: Fix various issues #2671

Merged
merged 14 commits into from
Dec 6, 2019
Merged

DLSpeech: Fix various issues #2671

merged 14 commits into from
Dec 6, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 5, 2019 •
edited
Loading

Fixes #2662. Fixes #2666.

Changelog Entry

  • Fixes #2658. Fix rendering of markdown images in IE11, by @corinagum in PR #2659
    • Added triple-buffering to reduce pops/cracks.
    • Enable Safari by upsampling to 48000 Hz.
    • Support detailed output format on Web Chat side.

Description

  • Pops and cracks are heard because AudioBuffer are expensive to create.
  • Safari was not working because it requires audio with sample rate >= 22050 Hz.
  • Detailed output format is now supported.

Specific Changes

  • Updated initialization code for Speech SDK to support detailed output format on Web Chat side
  • Upsampling audio data to 48000 Hz
  • Added a new triple-buffering player
  • Testing Added

@compulim compulim marked this pull request as ready for review December 5, 2019 12:53
corinagum
corinagum suggested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend doing a read through of the comments to make sure I kept the correct meaning while improving the phrasing. :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 61.198% when pulling 216087e on compulim:fix-dlspeech into 1f100e7 on microsoft:master.

corinagum
corinagum approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corinagum corinagum merged commit cb7657e into microsoft:master Dec 6, 2019
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@compulim @coveralls @corinagum