Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved core-js from devDeps to deps in directlinespeech-sdk package. #2727

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Moved core-js from devDeps to deps in directlinespeech-sdk package. #2727

merged 2 commits into from
Dec 13, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Dec 13, 2019 •
edited
Loading

Changelog Entry

Moved core-js from dev dependencies to dependencies in botframework-directlinespeech-sdk package, by @tonyanziano, in PR #2727

Description

botframework-directlinespeech-sdk package depends on core-js/features/observable but lists core-js as a dev dependency when it needs to be a production dependency so that it is installed properly when imported as a dependency.

Specific Changes

changed core-js from devDeps to deps in packages/directlinespeech

@corinagum corinagum merged commit 8610e61 into master Dec 13, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.121% when pulling 7258f32 on toanzian/core-js-dep into 7811093 on master.

@corinagum corinagum deleted the toanzian/core-js-dep branch December 13, 2019 03:52
@compulim compulim mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @corinagum