Added custom hooks to replace Timer component #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
compulim
approved these changes
Dec 27, 2019
| const handleInterval = useCallback(() => { | ||
| setTimer(nextTimer(value)); | ||
| }, [setTimer, value]); | ||
| useIntervalSince(value, TIMER_INTERVAL); |
There was a problem hiding this comment.
No callback function for useIntervalSince?
There was a problem hiding this comment.
If we don't change the useState hook to useRef in useIntervalSince, then setting the timer would rerender the component; otherwise, we would have to add a forceRender state hook to create a callback and rerender the timestamp.
There was a problem hiding this comment.
I am thinking about the hook design perspective, not about refactoring.
- If we name it
useForceRenderAtInterval, it works for me. - After starting the interval timer, how to stop it?
|
@compulim ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313
Changelog Entry
useTimeranduseIntervalSince- to replaceTimercomponent, by @tdurnford, in PR #2771Description
useTimeranduseIntervalSincehooksTimercomponent from theRelativeTimecomponent