Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CroppedImage PropTypes #2795

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Update CroppedImage PropTypes #2795

merged 2 commits into from
Jan 3, 2020

Conversation

tdurnford
Copy link
Contributor

Fixes #2647

Changelog Entry

Fixes #2647. Update the CroppedImage component PropType, by @tdurnford in PR #27XX

Description

Updated CroppedImage.propType.height to include strings.

  • Testing Added

@coveralls
Copy link

coveralls commented Jan 3, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 65.915% when pulling 2812e51 on tdurnford:2647 into 7946bde on microsoft:master.

corinagum
corinagum approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tdurnford tdurnford merged commit f9f9d6f into microsoft:master Jan 3, 2020
@compulim compulim mentioned this pull request Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning on react prop height of type string supplied to CroppedImage
3 participants
@tdurnford @coveralls @corinagum