Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable per-message avatar #2943

Merged
merged 33 commits into from
Feb 29, 2020
Merged

Customizable per-message avatar #2943

merged 33 commits into from
Feb 29, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 25, 2020 •
edited
Loading

Fixes #2857. Fixes #2904. Fixes #2881.

Changelog Entry

Added

Fixed

Samples

Description

Added avatar middleware for per-message avatar.

Developers can bring in custom design of avatars of different size and shape, and overlaid on top of current design. The avatar can be retrieved from activity.channelData or by any other means.

Specific Changes

  • Added avatarMiddleware: false | () => React.Element to prop of <BasicWebChat>
  • Added sample to show avatar decoration and portrait image
  • Moved VSCode debugger from Chrome to Edge Elements
  • Testing Added

tdurnford
tdurnford reviewed Feb 25, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
This was referenced Feb 25, 2020
Closed
Closed
@compulim compulim linked an issue Feb 25, 2020 that may be closed by this pull request
Add more bubble nub tests #2881
Closed
corinagum
corinagum approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending comments

@compulim compulim merged commit 0fbbb73 into microsoft:master Feb 29, 2020
@compulim compulim deleted the feat-customizable-avatar branch February 29, 2020 01:06
@compulim compulim mentioned this pull request Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@tdurnford tdurnford tdurnford left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL: Bubble nub with border radius Add more bubble nub tests [IC3] Per-message avatar
3 participants
@compulim @corinagum @tdurnford