Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Redux Devtools #3277

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

tpdewolf
Copy link
Contributor

Changelog Entry

Added

Description

Composed the redux store with the redux devtools enchancer. This makes it easier to debug the state.

Specific Changes

From:

const store = createStore(reducer, initialState || {}, applyMiddleware(...middlewares, sagaMiddleware));

To:

const store = createStore(
    reducer,
    initialState || {},
    composeWithDevTools(applyMiddleware(...middlewares, sagaMiddleware))
  );

  • Testing Added
    No tests added

@ghost
Copy link

ghost commented Jun 24, 2020

CLA assistant check
All CLA requirements met.

@compulim compulim self-assigned this Jun 24, 2020
@compulim
Copy link
Contributor

compulim commented Aug 5, 2020

@tpdewolf before we can accept your contribution, could you read the Contributor License Agreement?

@compulim
Copy link
Contributor

compulim commented Aug 9, 2020

I have updated the code with the following changes:

  • Moved Redux DevTools as an opt-in feature (createStore -> createStoreWithDevTools)
  • Expose DevTools "endpoint" in NPM package only
    • We don't have development favor of bundle (yet)
  • Added docs on disclaimer, code snippet, and limitations
  • Updated playground to support Redux DevTools
  • Use exact version for production dependencies

@compulim compulim merged commit 284339c into microsoft:master Aug 10, 2020
@tpdewolf tpdewolf deleted the feature/redux-devtools branch August 10, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants