Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post 4.10.1] Bump to [email protected] #3432

Merged
merged 5 commits into from
Sep 18, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Aug 21, 2020

Related to #3428.

[email protected] is still the latest as of 2020-09-16.

Changelog Entry

Changed

Description

Bump Cognitive Services Speech SDK to 1.13.1.

Changes from 1.10.1 to 1.13.1:

  • Stream.getReader() is gone
    • StreamReader is being implemented into the Stream class as read() function

Some code in Web Chat need to be updated because of the changes in 1.13.1.

Reading data from stream

Yesterday

This is pseudo code. Speech SDK use an implementation of Promise which is not compatible with JavaScript.

const reader = stream.getReader();
let chunk;

while ((chunk = await reader.read())) {
  // ...
}

Tomorrow

for (;;) {
  const chunk = new ArrayBuffer(4096);
  const numBytes = await stream.read(chunk);

  // ...
}

Design

Updated some code on Direct Line Speech SDK side to cope with changes from 1.10.1 -> 1.13.1.

Specific Changes

  • Bump Cognitive Services Speech SDK to 1.13.1
  • Update integration code in Direct Line Speech SDK
  • I have added tests and executed them locally
    • This is version bump, not expecting any changes to tests
  • I have updated CHANGELOG.md
  • I have updated documentation (N/A)

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
    • Will done during manual release testing
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Tests reviewed (coverage, legitimacy)
    • Not expecting any test changes

@compulim compulim changed the title Bump to [email protected] [Post 4.10.1] Bump to [email protected] Sep 3, 2020
@compulim compulim merged commit 31e92bd into microsoft:master Sep 18, 2020
@compulim compulim deleted the bump-speech-sdk-1.13.1 branch September 18, 2020 04:11
@compulim compulim mentioned this pull request Oct 29, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants