Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Target 4.10.1] Fix first delay of activity #3450

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 3, 2020

Fixes #3431

Changelog Entry

Fixed

  • Fixes #3431. Removed delay of first activity with replyToId pointing to a missing activity, by @compulim in PR #XXX

Description

When the first activity arrives, it always comes with a random replyToId, despite it is not actually replying to any conversation. This is a limitation of the design of SDK.

To mitigate the issue, Web Chat cannot delay the first (group of) activities even though the replyToId property is pointing to a potentially-transmitting activity.

Design

Please see the updated ACCESSIBILITY.md for details.

Specific Changes

  • Updated queueIncomingActivitySaga not to hold the activity if one of the following is true:
    • If it is the first activity in the transcript
    • If another activity waiting for the same replyToId is already rendered
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title Fix first delay of activity [Target 4.10.1] Fix first delay of activity Sep 3, 2020
docs/ACCESSIBILITY.md Outdated Show resolved Hide resolved
docs/ACCESSIBILITY.md Outdated Show resolved Hide resolved
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending a couple comments.

@corinagum corinagum self-assigned this Sep 3, 2020
@compulim compulim merged commit c21ecc3 into microsoft:master Sep 4, 2020
@compulim compulim deleted the fix-3431 branch September 4, 2020 08:24
@compulim compulim mentioned this pull request Sep 9, 2020
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First welcome message is delayed for 5 seconds
2 participants