-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Target 4.10.1] Fix first delay of activity #3450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
September 3, 2020 01:41
compulim
changed the title
Fix first delay of activity
[Target 4.10.1] Fix first delay of activity
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending a couple comments.
Co-authored-by: Corina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
replyToId
pointing to a missing activity, by @compulim in PR #XXXDescription
When the first activity arrives, it always comes with a random
replyToId
, despite it is not actually replying to any conversation. This is a limitation of the design of SDK.To mitigate the issue, Web Chat cannot delay the first (group of) activities even though the
replyToId
property is pointing to a potentially-transmitting activity.Design
Please see the updated
ACCESSIBILITY.md
for details.Specific Changes
queueIncomingActivitySaga
not to hold the activity if one of the following is true:replyToId
is already renderedCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewed