Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replyToId for Direct Line Speech adapter #3776

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 4, 2021

Fixes #3773

Changelog Entry

Fixes

  • Fixes #3773. Remove replyToId when using Direct Line Speech adapter, by @compulim in PR #3776

Description

Direct Line Speech adapter does not provide send receipt or any form of ACKs. The replyToId will always point to an activity outside of the transcript. Thus, a delay will always be introduced (for accessibility reasons).

Since receipts or send ACKs are not supported, we could remove the replyToId to prevent accessibility work to introduce the delay of showing activities.

Design

Specific Changes

  • Update Direct Line Speech chat adapter to remove replyToId for all incoming activities
  • Added tests to make sure 2 consecutive messages sent are received in a timely manner.
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - wondering if we'll need to do a cherrypick

@compulim compulim merged commit e0b9ad6 into microsoft:master Mar 4, 2021
@compulim compulim deleted the fix-3773 branch March 4, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response timeouts with DirectLineSpeech
2 participants