Remove replyToId for Direct Line Speech adapter #3776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixes
replyToId
when using Direct Line Speech adapter, by @compulim in PR #3776Description
Direct Line Speech adapter does not provide send receipt or any form of ACKs. The
replyToId
will always point to an activity outside of the transcript. Thus, a delay will always be introduced (for accessibility reasons).Since receipts or send ACKs are not supported, we could remove the
replyToId
to prevent accessibility work to introduce the delay of showing activities.Design
Specific Changes
replyToId
for all incoming activitiesCHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)