-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test reliability #3891
Merged
Merged
Improve test reliability #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
May 12, 2021 23:01
corinagum
reviewed
May 13, 2021
corinagum
reviewed
May 13, 2021
corinagum
reviewed
May 13, 2021
corinagum
reviewed
May 13, 2021
corinagum
reviewed
May 13, 2021
corinagum
reviewed
May 13, 2021
corinagum
approved these changes
May 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending a few comments (and questions, haha)
Co-authored-by: Corina <[email protected]>
compulim
added a commit
that referenced
this pull request
Jun 22, 2021
* Improve test reliability * Send tabs at once * Wait for all activities * scrollToTop should wait before and after scroll * Remove console.log * Stabilize screenshot before image snapshot * Add entry * Fix test break * Fix tests * Improve test reliability * Fix expectation * Improve test reliability * Improve page object model * Bump react-scroll-to-bottom * Bump [email protected] * Apply suggestions from code review Co-authored-by: Corina <[email protected]> Co-authored-by: Corina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
Now, we can show the image snapshot in console:
Design
Specific Changes
sendTab
andsendShiftTab
into a single callpageObjects.scrollToTop
marshal.js
andunmarshal.js
sendMessageViaSendBox
,waitForNumResponse
, to wait for X number of responses from botpageObjects.sendMessageViaSendBox('Hello, World!', { waitForNumResponse: 1 })
will wait for 1 response from bot[email protected]
for a race condition fixCHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)