Disable "noKeyboard" logic for IE11 #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
force-pushed
the
fix-3757-ie11-escape-key
branch
from
203236b
to
63123fc
Compare
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
|
I think this PR might resolve the following: #3825 Could you verify? |
corinagum
reviewed
May 20, 2021
corinagum
approved these changes
May 20, 2021
Co-authored-by: Corina <[email protected]>
|
This doesn't fix #3825. Going to open another PR. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixes
Description
IE11: ESCAPE key should not disable send box
After pressing ESCAPE key while focused on the transcript, IE11 will disable the send box.
This is because IE11 did not pick up
readonlyattribute change afterfocus()is called.The
noKeyboardflag, which set thereadonlyattribute, is disabling soft keyboard on mobile devices.Since IE11 don't run on mobile device, we can skip ignore the
noKeyboardflag on IE11.IE11: Should not focus on
<svg>icons(Adopted from this StackOverflow answer)
IE11 by default assume the
<svg>is focusable. Sincetabindexattribute is not supported in<svg>when IE11 implement it, we are using thefocusableattribute instead.Specific Changes
noKeyboardflag for IE11focusable={true}on all SVGs, they are icons for buttonsCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)CSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)