-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing for usePerformCardAction
hook
#3969
Merged
compulim
merged 3 commits into
microsoft:main
from
compulim:fix-3968-typing-use-perform-card-action
Aug 30, 2021
Merged
Fix typing for usePerformCardAction
hook
#3969
compulim
merged 3 commits into
microsoft:main
from
compulim:fix-3968-typing-use-perform-card-action
Aug 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
beyackle,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
June 30, 2021 17:06
cwhitten
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but CI is failing
compulim
force-pushed
the
fix-3968-typing-use-perform-card-action
branch
from
August 27, 2021 05:11
0cfb9e6
to
fbbf357
Compare
compulim
force-pushed
the
fix-3968-typing-use-perform-card-action
branch
from
August 27, 2021 05:12
fbbf357
to
08a068d
Compare
Fixed some ESLint errors:
|
compulim
added a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Sep 9, 2021
* Fix typing for usePerformCardAction * Update entry * Fix ESLint
compulim
added a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Sep 9, 2021
* Fix typing for usePerformCardAction * Update entry * Fix ESLint
compulim
added a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Sep 22, 2021
* Fix typing for usePerformCardAction * Update entry * Fix ESLint
compulim
added a commit
that referenced
this pull request
Sep 22, 2021
…ocus indicators (#4035) * Set default active descendant * Update to TypeScript * Add JSDoc * Update entry * Fix and clean up on focus activity * Add capability detection * Clean up * Clean up * Fix test * Fix tests * Fix tests * Fix tests * Clean up * Fix tests * Fix tests * Fix tests * Fix test * Add tests * Clean up * Fix typing for `usePerformCardAction` hook (#3969) * Fix typing for usePerformCardAction * Update entry * Fix ESLint * Fix ESLint * Clean up * Clean up * Add new focus indicator for suggested actions * Styling send box button with accessibility * Clean up * Add snapshots * Add entries * Typo * Fix color * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Improve test reliability * Improve test reliability: wait for render * Fix test reliability * Improve test reliability * Improve test reliability * Fix typings * Fix focusedActivityKey after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixes
usePerformCardAction
hook, by @compulim, in PR #3969Description
The typing for
usePerformCardAction
is wrong.We didn't catch this because we didn't not have any TypeScript code that use this hook yet. The one we have is JavaScript-in-TS, which do not type check the
usePerformCardAction
hook.Design
Specific Changes
usePerformCardAction
DirectLineCardAction.ts
AdaptiveCardRenderer.tsx
to TypeScript (type out the props, sotapAction
is of typeDirectLineCardAction
)CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)