-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECOND] Bump bf-dljs
and forked cldr-data
, cldr-data-downloader
#3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
[DRAFT] Fork
[DRAFT] Bump Jul 29, 2021
cldr-data
and cldr-data-downloader
bf-dljs
and forked cldr-data
, cldr-data-downloader
compulim
changed the title
[DRAFT] Bump
[SECOND] Bump Jul 30, 2021
bf-dljs
and forked cldr-data
, cldr-data-downloader
bf-dljs
and forked cldr-data
, cldr-data-downloader
compulim
requested review from
a-b-r-o-w-n,
beyackle,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
July 30, 2021 07:43
cwhitten
approved these changes
Aug 4, 2021
compulim
force-pushed
the
bump-cldr-data
branch
from
August 11, 2021 19:42
5602ced
to
ea0c1ba
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
cldr-data
andcldr-data-downloader
, in PR #3998./src
folderfs.readFileSync()
fromrequire()
when reading JSON filesnode:fs.mkdir()
and removedmkdirp
node:assert
to Jest/dist/
folder from project rooteslint
read-pkg-up
to determines parentpackage.json
lerna
to run theinstall
script, we need to relax howcldr-data
read from parentpackage.json
Description
cldr-data-downloader
has vulnerability and unlikely to be fixed in short term of time.To improve our code hygiene, we are forking
cldr-data-downloader
and its dependentcldr-data
.Also bumped
botframework-directlinejs
to0.15.0
.Design
cldr-data*
Both
cldr-data
andcldr-data-downloader
have MIT license. We forked the code and upgraded the codebase.ESLint
ecmaVersion
as2020
Instead of moving
ecmaVersion
tolatest
, I am keeping it as2020
while I am understanding why setting it tolatest
would trigger the following error:And the code for
useRenderAttachment.js
:Specific Changes
cldr-data
andcldr-data-downloader
to under/packages/support/
CHANGELOG
for details/*.tgz
to all.gitignore
filesbotframework-streaming
andbuffer
(used bybotframework-directlinejs
)strip-ansi
because it is ESM-only and Jest is not ESM readyhost.upload()
function to test harnessnpm run browser
), it will upload from<project-root>/__tests__/html/assets/uploads/
npm test
with Docker), it will upload from/home/seluser/Downloads
, which we will prepopulate the folder during Docker buildCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)