Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix Unicode CLDR database (#4404) #4406

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Hotfix Unicode CLDR database (#4404) #4406

merged 2 commits into from
Sep 6, 2022

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 6, 2022 •
edited
Loading

Related to #4404.

This is targeting a QFE branch of 4.14.1, not main.

Changelog Entry

Fixed

  • QFE: Fixes #4403. Patched Unicode CLDR database which caused file upload in Polish to appear blank, by @compulim, in PR #4406

Description

Hotfixing PR #4404 into qfe-4.14.1, which is from v4.14.1.

Design

This is for backporting #4404 with a few differences:

  • Test screenshot is different in the timestamp. This is because in newer version, we rectified how the "send status" work
  • No eslint-security policy in 4.14
  • cldr-data is a CJS package (4.14) instead of ESM (4.15)

Specific Changes

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim
Hotfix Unicode CLDR database (microsoft#4404)
496f924 
* Hotfix Unicode CLDR database

* Add entry

* Add test
@compulim
Update PR number
46f6746
@compulim compulim marked this pull request as ready for review September 6, 2022 23:35
@compulim
Copy link
Contributor Author

compulim commented Sep 6, 2022

The CI pipeline is skipped because configuration. I will trigger it manually after merge.

@compulim compulim merged commit 991a74e into microsoft:qfe-4.14.1 Sep 6, 2022
@compulim compulim deleted the fix-4403-qfe-4.14.1-second branch September 6, 2022 23:58
@compulim compulim mentioned this pull request Sep 7, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten

@srinaath srinaath Awaiting requested review from srinaath

@tdurnford tdurnford Awaiting requested review from tdurnford

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@beyackle beyackle Awaiting requested review from beyackle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compulim @a-b-r-o-w-n