Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIGH] Bump deps after release of 4.15.9 #4843

Merged
merged 23 commits into from
Sep 22, 2023
Merged

[HIGH] Bump deps after release of 4.15.9 #4843

merged 23 commits into from
Sep 22, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 1, 2023

Related to #4832.

Changelog Entry

Expand to see CHANGELOG.md

Changed

Description

Bump most deps to @latest after release of 4.15.9.

Design

We didn't bump:

  • lerna@7 is moving away from their npm link approach to npm workspaces, need funding for migration
  • glob@8 has its API updated and entrypoint changed, need funding for upgrade

Specific Changes

  • Pin /package.json/lerna@7
  • Pin /packages/support/cldr-data/package.json/glob@8
  • Various fixes
    • Update a few file to play nice with Prettier bump
    • redux no longer export Observable type, we now use the one from botframework-webchat-core
    • Add Readonly<T> for some props
    • Added eslint-plugin-import because @typescript-eslint deprecated some of their rules in favor of eslint-plugin-import
    • Disable import/no-named-as-default because we cannot control other packages
    • Configured [email protected] not to remove non-boolean attributes, such as <img alt>
  • Run npm run bump
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim
Copy link
Contributor Author

compulim commented Sep 9, 2023

Failed tests will be fixed in #4846. We can probably merge this PR afterward.

@compulim compulim changed the title Bump deps after release of 4.15.9 [HIGH] Bump deps after release of 4.15.9 Sep 15, 2023
tdurnford
tdurnford previously approved these changes Sep 20, 2023
@compulim compulim merged commit 8d04e66 into main Sep 22, 2023
10 checks passed
@compulim compulim deleted the bump-deps-4.15.10-0 branch September 22, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants