Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent theme] Hide buttons, suggested actions FnF and flow layout, DTMF FnF #5132

Merged
merged 9 commits into from
Apr 13, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 13, 2024

Changelog Entry

Added

  • (Experimental) Added botframework-webchat-fluent-theme package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny, in PR #5120
    • Added support of styleOptions.hideUploadButton, in PR #5132
    • Added styleOptions.hideTelephoneKeypadButton and default to true, in PR #5132
    • Fit-and-finish on suggested actions and telephone keypad, in PR #5132
    • Fixed to keep telephone keypad on-screen on click, in PR #5132

Description

Some fit-and-finish work for suggested actions and telephone keypad in Fluent skin pack. Please look at Specific Changes section for details.

Design

styleOptions.hideTelephoneKeypad

Added a new hideTelephoneKeypad style options. However, this is marked as experimental. Soon, we will be working on input modality and this style options will probably be superseded by the input modality feature.

Also, the telephone keypad UX should be made available to our current white-label experience.

Specific Changes

  • Updated suggested actions to support styleOptions.suggestedActionLayout of "flow"
    • "carousel" layout is currently not supported
  • Updated suggested actions look-and-feel
    • Tighter and shorter height, smaller icon
  • Updated telephone keyboard not to close on tap
  • Updated color of ruby in telephone keyboard button for contrast ratio
  • Hid telephone keypad button by default
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review April 13, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants