-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: add telephone keypad information message #5140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
April 19, 2024 18:57
compulim
reviewed
Apr 19, 2024
compulim
reviewed
Apr 19, 2024
compulim
previously approved these changes
Apr 19, 2024
compulim
approved these changes
Apr 19, 2024
This was referenced Aug 1, 2024
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny, in PR #5120<LocalizeString />
component which can be used to localize strings, by @OEvgeny in PR #5140The component supports markdown formatting. Usage:
Description
This adds an info message regarding telephone keypad limited functionality, and everything needed to adjust the message.
The
TELEPHONE_KEYPAD_INPUT_MESSAGE
string doesn't contain the link by default, but can be adjusted by consumers to include the desired "Learn more" link.Design
The
LocalizedString
component uses own instance of themarkdown-it
parser to avoid potential collisions with existing usage.The
better-links
plugin was adopted for the component needs. It acceptslinkOptions
and even custom decoration functions without recreating theMarkdownIt
instance.Specific Changes
LocalizedString
componentbetterLinks
plugin to be usedLocalizedString
componentTELEPHONE_KEYPAD_INPUT_MESSAGE
localization keyTEXT_INPUT_LENGTH_EXCEEDED_ALT
messageTEXT_INPUT_LENGTH_EXCEEDED_ALT
message with markdown stringCHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedz-index
)Documents reviewed (docs, samples, live demo)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)