Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: decorator import in CJS legacy envs #5231

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix: decorator import in CJS legacy envs #5231

merged 5 commits into from
Jun 28, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Jun 27, 2024

Fixes #

Changelog Entry

  • Fixed decorator import in legacy CommonJS environments, in 5231, by @OEvgeny

Description

This adds missing files to the npm package, so the decorator module can be properly located in environments lacking exports field support.

Design

  • Fixed files field to include top level js files

Specific Changes

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review June 27, 2024 23:04
beyackle2
beyackle2 previously approved these changes Jun 27, 2024
compulim
compulim previously approved these changes Jun 27, 2024
@OEvgeny OEvgeny requested a review from compulim June 28, 2024 16:44
@OEvgeny OEvgeny enabled auto-merge (squash) June 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants