Remove openenclave.verifyOpenEnclaveEvidence JS API (#6236)

CHANGELOG.md

@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 - Added TypeScript `TypedKvSet` and `ccfapp.typedKv<K>` to facilitate set handling from application code.
 
+### Removed
+
+- Removed unused `openenclave.verifyOpenEnclaveEvidence` API from JS/TS.
+
 ## [5.0.0-dev17]
 
 [5.0.0-dev17]: https://github.com/microsoft/CCF/releases/tag/ccf-5.0.0-dev17

CMakeLists.txt

@@ -334,7 +334,6 @@ set(CCF_JS_SOURCES
     ${CCF_DIR}/src/js/ffi_plugins.cpp
     ${CCF_DIR}/src/js/extensions/console.cpp
     ${CCF_DIR}/src/js/extensions/math/random.cpp
-    ${CCF_DIR}/src/js/extensions/openenclave.cpp
     ${CCF_DIR}/src/js/extensions/snp_attestation.cpp
     ${CCF_DIR}/src/js/extensions/ccf/consensus.cpp
     ${CCF_DIR}/src/js/extensions/ccf/converters.cpp

include/ccf/js/common_context.h

@@ -8,7 +8,6 @@
 #include "ccf/js/extensions/ccf/kv.h"
 #include "ccf/js/extensions/console.h"
 #include "ccf/js/extensions/math/random.h"
-#include "ccf/js/extensions/openenclave.h"
 #include "ccf/js/extensions/snp_attestation.h"
 
 namespace ccf::js
@@ -39,10 +38,6 @@ namespace ccf::js
       Base::add_extension(
         std::make_shared<ccf::js::extensions::CryptoExtension>());
 
-      // add openenclave.*
-      Base::add_extension(
-        std::make_shared<ccf::js::extensions::OpenEnclaveExtension>());
-
       // add snp_attestation.*
       Base::add_extension(
         std::make_shared<ccf::js::extensions::SnpAttestationExtension>());

js/ccf-app/src/global.ts

@@ -743,32 +743,6 @@ export interface CCF {
   enableMetricsLogging(enable: boolean): boolean;
 }
 
-export const openenclave: OpenEnclave = (<any>globalThis).openenclave;
-
-export interface EvidenceClaims {
-  claims: { [name: string]: ArrayBuffer };
-  customClaims: { [name: string]: ArrayBuffer };
-}
-
-export interface OpenEnclave {
-  /**
-   * Verifies Open Enclave evidence and returns the claims of the evidence.
-   *
-   * @param format The optional format id of the evidence to be verified as
-   *  a UUID of the form "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx".
-   *  If this parameter is `undefined`, the evidence and endorsement
-   *  must either contain data with an attestation header holding a valid
-   *  format id, or be an Open Enclave report generated by the legacy API function
-   *  `oe_get_report()`. Otherwise, this parameter must be a valid format id, and
-   *  the evidence and endorsements data must not be wrapped with an attestation header.
-   */
-  verifyOpenEnclaveEvidence(
-    format: string | undefined,
-    evidence: ArrayBuffer,
-    endorsements?: ArrayBuffer,
-  ): EvidenceClaims;
-}
-
 export interface TcbVersion {
   boot_loader: number;
   tee: number;

js/ccf-app/src/polyfill.ts

@@ -29,8 +29,6 @@ import {
   CryptoKeyPair,
   WrapAlgoParams,
   DigestAlgorithm,
-  EvidenceClaims,
-  OpenEnclave,
   SnpAttestation,
   SnpAttestationResult,
   SigningAlgorithm,
@@ -630,18 +628,6 @@ class CCFPolyfill implements CCF {
 
 (<any>globalThis).ccf = new CCFPolyfill();
 
-class OpenEnclavePolyfill implements OpenEnclave {
-  verifyOpenEnclaveEvidence(
-    format: string | undefined,
-    evidence: ArrayBuffer,
-    endorsements?: ArrayBuffer,
-  ): EvidenceClaims {
-    throw new Error("Method not implemented.");
-  }
-}
-
-(<any>globalThis).openenclave = new OpenEnclavePolyfill();
-
 class SnpAttestationPolyfill implements SnpAttestation {
   verifySnpAttestation(
     evidence: ArrayBuffer,