Skip to content

Commit

Permalink
Ignore time in did:x509 resolve (#6576)
Browse files Browse the repository at this point in the history
(cherry picked from commit 19561dd)

# Conflicts:
#	.snpcc_canary
#	CHANGELOG.md
  • Loading branch information
achamayou committed Oct 17, 2024
1 parent ed595d5 commit fca5727
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .snpcc_canary
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
O \ o | /
/-xXx--//-----x=x--/-xXx--/---x---->>>--/
...
/\/\(-_-)
/\/\d(-_-)b/\/\
--/\
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [5.0.7]

[5.0.7]: https://github.com/microsoft/CCF/releases/tag/ccf-5.0.7

- Ignore time when resolving did:x509 against x5chain, resolution establishes a point-in-time endorsement, not ongoing validity (#6575).

## [5.0.6]

[5.0.6]: https://github.com/microsoft/CCF/releases/tag/ccf-5.0.6

### Bug fixes

- Added COSE signature verification to consume signature transactions from upgraded primary (#6495).

## [5.0.5]
Expand Down
3 changes: 2 additions & 1 deletion src/node/uvm_endorsements.h
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ namespace ccf

const auto& did = phdr.iss;

auto did_document_str = didx509::resolve(pem_chain, did);
auto did_document_str =
didx509::resolve(pem_chain, did, true /* ignore time */);
did::DIDDocument did_document = nlohmann::json::parse(did_document_str);

if (did_document.verification_method.empty())
Expand Down

0 comments on commit fca5727

Please sign in to comment.