Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic replacement of shutdown node #5514

Merged

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 8, 2023

Performs node replacement as an atomic transaction when using --add-new-node-after-primary-stops.

@achamayou achamayou requested a review from a team as a code owner August 8, 2023 11:14
@achamayou achamayou marked this pull request as draft August 8, 2023 11:15
@ccf-bot
Copy link
Collaborator

ccf-bot commented Aug 8, 2023

atomic_replacement_of_shutdown_node@74101 aka 20230808.35 vs main ewma over 19 builds from 73734 to 74091

Click to see table

main

build_id build_number Commit latency factor pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_virtual_cft^ ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem
73734 20230801.14 0.812897 62432.8 45721.1 50273.2 35728.9 2.51822e+07 55080.9 12362 19965 1.88908e+07 12983.3 20133.8 1.05021e+07 4541.17 22758.9 1.25993e+07 6339.77 1.67936e+07 3465.49 6644.5 6.30784e+06 3308.33 1741.68 1.05021e+07 42491 1436.76 1.05021e+07 1425.69 1.05021e+07 834723 1.18456e+06 8.15449e+06 3.08476e+07 nan nan nan
73745 20230801.18 0.790283 73698.5 45486.7 47459.5 35368.8 2.51822e+07 58615.3 12475.9 19972.8 1.88908e+07 12740.3 20042.2 1.05021e+07 4468.63 22723.7 1.25993e+07 6680.54 1.67936e+07 3544.11 6173.8 6.30784e+06 3290.04 1743.88 1.05021e+07 48480.8 1431.08 1.05021e+07 1429.18 1.05021e+07 838542 1.18022e+06 8.14615e+06 3.08713e+07 4615.6 1748.8 8.40499e+06
73777 20230802.4 0.768526 70649.9 45650.2 49459.7 36072.1 2.30851e+07 59718.2 12475.4 19974.6 1.88908e+07 12926.7 20134 1.05021e+07 4458.58 22745.7 1.25993e+07 6713.41 1.67936e+07 3575.58 6595.7 6.30784e+06 3284.09 1744 1.05021e+07 43652.4 1437.85 1.05021e+07 1430.69 1.05021e+07 828420 1.17762e+06 8.13567e+06 3.10068e+07 4625.2 1748.2 8.40499e+06
73794 20230802.11 0.788545 54864.6 45820.2 49614.7 34513.7 2.93765e+07 57118.1 12272.1 20061.5 1.88908e+07 12965.6 20114.6 1.05021e+07 4489.18 22119 1.46964e+07 6360.75 1.67936e+07 3549.16 6653.2 6.30784e+06 3302.1 1740.89 1.05021e+07 50154.3 1423.44 1.05021e+07 1426.62 1.05021e+07 829086 1.18336e+06 8.17539e+06 3.08434e+07 4516.6 1714.8 1.25993e+07
73801 20230802.13 0.782836 60729.3 45831.3 49515.5 35020 2.93765e+07 56374.6 12362 20064.3 1.88908e+07 13037.1 20060.1 1.05021e+07 4408.51 22220.1 1.46964e+07 6405.25 1.67936e+07 3558.21 6531.2 6.30784e+06 3276.33 1758.14 1.05021e+07 46647.2 1438.79 1.05021e+07 1433.93 1.05021e+07 838844 1.18438e+06 8.15654e+06 3.07019e+07 4496.4 1723.6 1.25993e+07
73815 20230802.17 0.79794 65856.4 45676.9 50307.6 34856.8 2.93765e+07 56414.7 12384.1 19896.7 1.88908e+07 13247 19669.9 1.05021e+07 4463.75 21987.3 1.46964e+07 6352.19 1.67936e+07 3522.27 6611.5 6.30784e+06 3264.72 1741.79 1.05021e+07 50788.5 1423.52 1.05021e+07 1425.12 1.05021e+07 828193 1.17909e+06 8.17271e+06 3.21028e+07 4513.9 1720.4 1.25993e+07
73824 20230802.20 0.7785 57879.8 43601.8 48289.8 34827.5 3.14737e+07 55191.4 12274.3 19932.6 1.88908e+07 13203.9 19936.6 1.05021e+07 4477.96 21729.5 1.46964e+07 6310.38 1.67936e+07 3479.34 6422.6 6.30784e+06 3275.41 1733.84 1.05021e+07 42443.7 1418.02 1.05021e+07 1403.56 1.05021e+07 832460 1.18064e+06 8.15329e+06 3.09165e+07 4491.2 1704.9 1.25993e+07
73833 20230803.1 0.767432 54270 44054.3 48003.5 34368.6 2.93765e+07 55051.9 12290.9 19895.7 1.88908e+07 12933.8 20037.1 1.05021e+07 4448.1 22029.9 1.46964e+07 6344.16 1.67936e+07 3480.84 6509.4 6.30784e+06 3387.2 1739.61 1.05021e+07 46396 1434.2 1.05021e+07 1425.8 1.05021e+07 830551 1.18078e+06 8.16841e+06 3.06987e+07 4552.3 1712.4 1.25993e+07
73844 20230803.7 0.78827 69882.2 43645.5 47228.6 34977.9 2.93765e+07 48176.8 12866.8 19982.3 1.67936e+07 12950.2 20054.3 1.05021e+07 4434.39 22226.4 1.46964e+07 6684.56 1.67936e+07 3489.54 6471.4 6.30784e+06 3252.94 1740.9 1.05021e+07 45790.4 1431.06 1.05021e+07 1416.79 1.05021e+07 829927 1.17775e+06 8.15355e+06 3.08629e+07 4433.2 1722.5 1.25993e+07
73857 20230803.12 0.808633 63751.2 43636.1 47165.4 34818.9 2.93765e+07 54191.6 12452.3 19988.7 1.88908e+07 13090.4 20057.8 1.05021e+07 4442.91 22275 1.46964e+07 6721.4 1.67936e+07 3471.35 6622 6.30784e+06 3264.04 1745.82 1.05021e+07 49838.7 1438.49 1.05021e+07 1431.17 1.05021e+07 832243 1.17951e+06 8.17294e+06 3.0848e+07 4490.2 1733 1.25993e+07
73868 20230803.16 0.767168 52677.1 46069.3 42909.1 34448.2 2.93765e+07 55223.9 12324 19972.5 1.88908e+07 12946 20066.7 1.05021e+07 4419.54 22104.3 1.46964e+07 6719.59 1.67936e+07 3490.07 6474.7 6.30784e+06 3270.05 1738.6 1.05021e+07 45949.3 1414.21 1.05021e+07 1418.57 1.05021e+07 839690 1.17769e+06 8.15316e+06 3.08424e+07 4511.7 1714 1.25993e+07
73883 20230803.21 0.826996 67845.9 43840 47764.4 34890.4 2.93765e+07 55231.5 12297.1 19952.7 1.67936e+07 13018 20003 1.05021e+07 4453.54 22083.8 1.46964e+07 6349.36 1.67936e+07 3476.76 6567.7 6.30784e+06 3239.58 1740.99 1.05021e+07 48176.7 1432.52 1.05021e+07 1425.47 1.05021e+07 828851 1.17836e+06 8.17366e+06 3.06183e+07 4540.4 1721.8 1.25993e+07
73892 20230803.24 0.802924 69799.4 43948.7 47878 34769.4 2.93765e+07 54015.7 12562.4 20074.3 1.88908e+07 13205.3 20138.1 1.25993e+07 4449.44 22306.6 1.67936e+07 6368.94 1.67936e+07 3483.29 6550.5 6.30784e+06 3262.22 1740.73 1.05021e+07 48657.6 1420.98 1.05021e+07 1430.83 1.05021e+07 831510 1.17993e+06 8.14888e+06 3.1209e+07 4552 1728.6 1.25993e+07
73900 20230803.26 0.761475 62961.5 45747.9 47879 34835.1 2.93765e+07 54591.3 12539.3 19968.8 1.88908e+07 13050.1 20210.4 1.25993e+07 4460.49 22370.7 1.67936e+07 6375.42 1.67936e+07 3549.61 6574.4 6.30784e+06 3369.08 1740.58 1.05021e+07 50311.8 1436.48 1.05021e+07 1427.37 1.05021e+07 802461 1.17535e+06 8.15193e+06 3.2663e+07 4452.6 1717.9 1.25993e+07
73938 20230804.13 0.794691 64405.2 45536.3 47977.5 34533.2 2.93765e+07 53871.1 12812.8 19979.8 1.88908e+07 12907.7 20095.9 1.25993e+07 4482.1 22273 1.67936e+07 6368.55 1.67936e+07 3568.79 6664.7 6.30784e+06 3288.24 1744.42 1.05021e+07 48176.6 1434.54 1.05021e+07 1430.22 1.05021e+07 837139 1.17642e+06 8.14956e+06 3.09338e+07 4520.8 1728.8 1.25993e+07
73955 20230807.6 0.801307 52415.6 43934.3 48026.8 34825.7 2.93765e+07 54527.6 12421.1 20091 1.88908e+07 13186.7 20209 1.25993e+07 4423.14 22457 1.67936e+07 6721.54 1.67936e+07 3572.61 6526.9 6.30784e+06 3245.74 1742.64 1.05021e+07 48325.6 1434.78 1.05021e+07 1430.76 1.05021e+07 834230 1.17948e+06 8.15618e+06 3.1666e+07 4516.7 1720.9 1.25993e+07
74021 20230808.12 0.806516 76483.6 43681.8 48001 34496.1 2.93765e+07 54088.3 12857.1 19886.6 1.88908e+07 13210.9 20156.5 1.25993e+07 4461.7 22130.3 1.67936e+07 6369.53 1.67936e+07 3405.82 6461.2 6.30784e+06 3258.26 1740.76 1.05021e+07 48007.7 1426.71 1.05021e+07 1426.32 1.05021e+07 836568 1.17363e+06 8.17483e+06 3.079e+07 4509 1721.8 1.25993e+07
74045 20230808.18 0.798632 71140.8 43896.8 48686.2 34498.6 2.93765e+07 54294.8 12302.7 20059.3 1.88908e+07 12966 20193.6 1.25993e+07 4424.98 22276.2 1.67936e+07 6707.62 1.67936e+07 3461.48 6490.1 6.30784e+06 3361.39 1744.67 1.05021e+07 44197.7 1419.59 1.05021e+07 1423.88 1.05021e+07 837488 1.18204e+06 8.15472e+06 3.06642e+07 4498.2 1718.8 1.25993e+07
74091 20230808.32 0.816875 57986 45839.1 48192.1 34255.1 3.14737e+07 53263.5 12255.7 19912.8 1.88908e+07 13172.8 20200.7 1.05021e+07 4472.93 22149.1 1.67936e+07 6685.9 1.67936e+07 3478.76 6559 6.30784e+06 3266.03 1740.49 1.05021e+07 46144.6 1436.63 1.05021e+07 1420.62 1.05021e+07 832268 1.17896e+06 8.13069e+06 3.08397e+07 4494.9 1712.5 1.25993e+07

atomic_replacement_of_shutdown_node

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_mt_virtual_cft^ hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem
74101 20230808.35 0.821992 43803.9 47632.9 52099.1 4387.3 12371.3 12812.6 4436.19 3464.03 3263 82871.7 40683.4 19825.7 1.88908e+07 20058.6 1.25993e+07 21776.5 1.67936e+07 1685.8 1.25993e+07 6295.35 1.67936e+07 6434.3 6.30784e+06 1717.32 1.05021e+07 1418.4 1.05021e+07 1408.68 1.05021e+07 815252 1.17677e+06 8.15439e+06 3.08759e+07 38313.5 2.72794e+07

images

@achamayou achamayou marked this pull request as ready for review August 8, 2023 13:22
@achamayou achamayou merged commit 9c4d247 into microsoft:main Aug 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants