Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SNP CI authentication #5552

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Fix SNP CI authentication #5552

merged 11 commits into from
Aug 17, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 16, 2023

DefaultAzureCredential is fairly ambiguous, and may get resolved to a managed identity created by the VM used by the CI pool. Being more specific and explicitly using the CLI authentication executed earlier in the pipeline is preferable.

https://learn.microsoft.com/en-us/python/api/overview/azure/identity-readme?view=azure-python#defaultazurecredential

Also remove the unused secondary deployment logic to simplify the CI.

Fixes #5521

@ccf-bot
Copy link
Collaborator

ccf-bot commented Aug 16, 2023

aci_exp@74624 aka 20230817.9 vs main ewma over 20 builds from 74198 to 74613

Click to see table

main

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor pi_basic_mt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem pi_basic_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
74198 20230809.27 38024.5 2.72794e+07 0.786392 71371.8 20027.5 1.88908e+07 20218.1 1.25993e+07 22184.1 1.67936e+07 45753.8 47988.3 53468 1731.2 1.25993e+07 4523.9 6713.28 1.67936e+07 6554.2 6.30784e+06 12375.5 13240.8 4468.77 1745.15 1.05021e+07 3481.5 3276 1440.4 1.05021e+07 48462.2 1433.28 1.05021e+07 820068 1.17261e+06 8.17294e+06 3.06729e+07
74209 20230810.2 39033.7 2.51822e+07 0.8281 68935.7 20029.8 1.88908e+07 20147.2 1.25993e+07 22127 1.67936e+07 45612.7 47686.3 53371.5 1732.5 1.25993e+07 4484.1 6694.4 1.67936e+07 6634.1 6.30784e+06 12454.6 13357 4472.56 1744.4 1.05021e+07 3465.07 3186.1 1439.43 1.05021e+07 45659.4 1430.93 1.05021e+07 826800 1.17717e+06 8.09717e+06 3.08662e+07
74219 20230810.7 38833.2 2.72794e+07 0.792962 81395.7 20051 1.88908e+07 20143.2 1.25993e+07 22240 1.67936e+07 45726.1 47798.9 51803.2 1734.9 1.25993e+07 4492.6 6415.64 1.67936e+07 6477.9 6.30784e+06 12289.7 12886.8 4430.02 1745.88 1.05021e+07 3447.97 3364.46 1437.82 1.05021e+07 46301.9 1431.42 1.05021e+07 835807 1.17952e+06 8.17196e+06 3.09426e+07
74245 20230810.11 38844.9 2.72794e+07 0.777765 77143.4 20074.9 1.88908e+07 20112 1.25993e+07 22037.1 1.67936e+07 43727.5 47325.4 52670.2 1725.4 1.25993e+07 4477.5 6698.89 1.67936e+07 6550.3 6.30784e+06 12427.7 13126.6 4481.45 1737.5 1.05021e+07 3486.95 3311.64 1434.15 1.05021e+07 44421.9 1422 1.05021e+07 836940 1.17657e+06 8.15322e+06 3.08183e+07
74291 20230810.18 36102.1 2.72794e+07 0.821145 74682.1 19934.4 1.88908e+07 20116 1.25993e+07 22221.4 1.67936e+07 45729.3 48220.7 54045.9 1729 1.25993e+07 4527.7 6368.12 1.67936e+07 6484.6 6.30784e+06 12318.8 13038.3 4430.26 1746.12 1.05021e+07 3545.51 3380.55 1439.84 1.05021e+07 50616.1 1426.05 1.05021e+07 836343 1.17805e+06 8.15264e+06 2.98904e+07
74354 20230810.33 38639.9 2.72794e+07 0.812767 61954.9 19946.2 1.88908e+07 20162.1 1.25993e+07 22112.1 1.67936e+07 45640 47642.4 53935.3 1725.6 1.25993e+07 4517.2 6689.93 1.67936e+07 6609.9 6.30784e+06 12379.8 13370.8 4450.43 1744.63 1.05021e+07 3571.44 3345.81 1435.11 1.05021e+07 46737.5 1428.85 1.05021e+07 830213 1.17571e+06 8.14674e+06 3.0835e+07
74367 20230811.2 38103 2.72794e+07 0.803956 62845.8 19852.6 1.88908e+07 20096.7 1.25993e+07 21937.4 1.67936e+07 45566.8 47760.7 53872 1724.1 1.25993e+07 4526.9 6352.84 1.67936e+07 6514 6.30784e+06 12337.1 13317 4412.68 1751.81 1.05021e+07 3478.6 3372.57 1433.12 1.05021e+07 42185.9 1437.58 1.05021e+07 825048 1.16931e+06 8.1553e+06 3.06743e+07
74378 20230811.7 38650.5 2.72794e+07 0.802305 88492.2 19903.3 1.88908e+07 20171.7 1.25993e+07 22216.7 1.67936e+07 45677.6 48432.2 54684.7 1719.9 1.25993e+07 4539.7 6370.76 1.67936e+07 6518.5 6.30784e+06 12416.2 13091.7 4453.32 1745.05 1.05021e+07 3563.15 3344.07 1438.55 1.05021e+07 42180.8 1430.81 1.05021e+07 834643 1.18197e+06 8.15296e+06 3.11369e+07
74393 20230811.11 38890.9 2.51822e+07 0.802048 72880.2 20033.6 1.88908e+07 20189.8 1.25993e+07 22213.1 1.67936e+07 45663.8 47632.7 53582.1 1724.7 1.25993e+07 4489.6 6358.91 1.67936e+07 6522.4 6.30784e+06 12392.7 13312.2 4458.86 1745.64 1.05021e+07 3496.9 3288.31 1439.43 1.05021e+07 47361.6 1423.98 1.05021e+07 829334 1.1786e+06 8.15455e+06 3.08582e+07
74405 20230811.13 38804.4 2.72794e+07 0.799883 84875.2 19943.4 1.67936e+07 20158.2 1.05021e+07 22107.1 1.67936e+07 45739.8 44854.1 53826.6 1727.4 1.25993e+07 4505.2 6692.16 1.67936e+07 6591.3 6.30784e+06 12458.7 12889.8 4433.17 1746.31 1.05021e+07 3576.83 3264.12 1427.77 1.05021e+07 43371.9 1425.5 1.05021e+07 835000 1.17701e+06 8.15566e+06 3.09029e+07
74425 20230814.4 38492.4 2.72794e+07 0.788539 81005.3 20058.5 1.88908e+07 20066.3 1.25993e+07 22245.3 1.67936e+07 43766.9 47791.6 53044.4 1728.7 1.05021e+07 4476.8 6397.71 1.67936e+07 6613.1 6.30784e+06 12324.6 12860.2 4480.33 1742.48 1.05021e+07 3439.84 3305.9 1439.23 1.05021e+07 45672.3 1431.17 1.05021e+07 838021 1.1778e+06 8.15507e+06 3.0784e+07
74432 20230814.7 38424 2.72794e+07 0.817276 75646 19999.3 1.88908e+07 20133.7 1.25993e+07 22073.4 1.67936e+07 45886.5 47469.4 53530.9 1717.3 1.25993e+07 4520.6 6341.62 1.67936e+07 6462 6.30784e+06 12327.4 12921.6 4425.4 1744.92 1.05021e+07 3477.25 3266.76 1422.1 1.05021e+07 48165.2 1425.52 1.05021e+07 825462 1.1799e+06 8.13835e+06 3.08137e+07
74454 20230815.3 38576.9 2.72794e+07 0.801873 69841.3 19840.7 1.88908e+07 20095.1 1.25993e+07 22097.1 1.67936e+07 43713.4 48179.3 53480.5 1725.2 1.25993e+07 4445.3 6340.93 1.67936e+07 6641.6 6.30784e+06 12483.5 12750.5 4457.26 1744.28 1.05021e+07 3500.77 3263.54 1439.26 1.05021e+07 45794.6 1426.85 1.05021e+07 829402 1.18158e+06 8.15537e+06 3.11412e+07
74461 20230815.7 39100.5 2.72794e+07 0.818769 67371.9 19972 1.88908e+07 20170.6 1.05021e+07 22108.7 1.67936e+07 46047.3 46914.7 53628.8 1714.7 1.25993e+07 4533.4 6341.63 1.67936e+07 6474.1 6.30784e+06 12304.9 12896.9 4441.12 1738.21 1.05021e+07 3574.64 3250.43 1437.82 1.05021e+07 45998.4 1432.91 1.05021e+07 828701 1.18254e+06 8.15137e+06 3.22662e+07
74474 20230815.11 38642 2.72794e+07 0.794527 83323.4 20045.8 1.88908e+07 20128.8 1.25993e+07 22175.6 1.67936e+07 44006.6 48130.1 53133.7 1735.7 1.25993e+07 4482.8 6383.4 1.67936e+07 6568.6 6.30784e+06 12321.3 13339.6 4444.74 1742.1 1.05021e+07 3467.96 3266.21 1434.21 1.05021e+07 46193.8 1422.91 1.05021e+07 835648 1.17698e+06 8.1401e+06 3.08666e+07
74510 20230816.1 37360.1 2.72794e+07 0.79391 70797.5 19985.7 1.88908e+07 20090.3 1.25993e+07 22138 1.67936e+07 45664.3 48310.3 53485.5 1735.4 1.25993e+07 4469.4 6719.14 1.67936e+07 6508 6.30784e+06 12494.1 13111.7 4466.5 1746.42 1.05021e+07 3466.26 3270.1 1440.41 1.05021e+07 42854.4 1433.43 1.05021e+07 839230 1.17803e+06 8.15309e+06 3.08174e+07
74553 20230816.14 38976.8 2.72794e+07 0.80085 83052.6 20103.4 1.88908e+07 20279.8 1.25993e+07 22556.1 1.67936e+07 45971.2 48460.4 54174.5 1724.4 1.25993e+07 4517.1 6672.96 1.67936e+07 6484.6 6.30784e+06 12271.3 12986.3 4431.14 1745.01 1.05021e+07 3571.73 3377.06 1436.22 1.05021e+07 48418.1 1429.13 1.05021e+07 822826 1.18085e+06 8.17235e+06 3.06568e+07
74583 20230816.21 38778.8 2.72794e+07 0.793694 78106.8 20066.9 1.88908e+07 20261.6 1.25993e+07 22514.4 1.67936e+07 45640.7 48315.5 53242.5 1731.6 1.25993e+07 4534.9 6403.27 1.67936e+07 6531.2 6.30784e+06 12304.8 13098.3 4454.98 1742.57 1.05021e+07 3477.94 3266.07 1434.72 1.05021e+07 44499 1428.25 1.05021e+07 828489 1.17797e+06 8.15426e+06 3.09478e+07
74600 20230817.1 38876.7 2.72794e+07 0.783219 77267.9 20052.3 1.88908e+07 20283.5 1.25993e+07 22580.6 1.67936e+07 45662.1 48214.4 54245.6 1724.6 1.25993e+07 4547 6363.23 1.67936e+07 6605.3 6.30784e+06 12340.4 12920.2 4434.02 1745.31 1.05021e+07 3464.06 3356.34 1436.91 1.05021e+07 44612.6 1433.67 1.05021e+07 828627 1.18077e+06 8.14194e+06 2.96756e+07
74613 20230817.6 39514.1 2.72794e+07 0.804638 89897.4 20086.4 1.88908e+07 20320.4 1.25993e+07 22695.3 1.67936e+07 43498.7 47884.5 52987.8 1734.4 1.05021e+07 4526.1 6357.59 1.67936e+07 6523.1 6.30784e+06 12431.7 13008.1 4483.36 1742.34 1.05021e+07 3511.6 3275.81 1433.89 1.05021e+07 43634.7 1432.2 1.05021e+07 837791 1.17873e+06 8.1704e+06 3.07212e+07

aci_exp

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
74580 20230816.20 39171.2 2.72794e+07 0.78608 87566.7 45813.7 48796.4 53615 20012.4 1.88908e+07 4528.1 20332.2 1.25993e+07 12399.2 22458.1 1.67936e+07 13327.8 4377.92 1728.1 1.25993e+07 3530.87 6711.03 1.67936e+07 6522 6.30784e+06 3387.65 1739.72 1.05021e+07 47005.4 1437.76 1.05021e+07 1427.81 1.05021e+07 827260 1.17852e+06 8.09669e+06 2.98669e+07
74596 20230816.25 39404.7 2.93765e+07 0.730796 64237.3 45439.8 48339.5 53828.2 20097.1 1.88908e+07 4517.8 20301.8 1.25993e+07 12397.8 22411.9 1.67936e+07 13080.6 4453.67 1725.4 1.25993e+07 3488.5 6390.81 1.67936e+07 6569.4 6.30784e+06 3279.96 1741.32 1.05021e+07 45413 1420.95 1.05021e+07 1405.14 1.05021e+07 830153 1.17599e+06 8.15254e+06 3.13615e+07
74610 20230817.5 39936.3 2.93765e+07 0.817437 77865.4 43778.3 47575.1 54035 20074.4 1.88908e+07 4461.9 20232.3 1.25993e+07 12492.9 22420.3 1.46964e+07 13113.4 4443.44 1731.3 1.25993e+07 3575.18 6711.48 1.67936e+07 6506 6.30784e+06 3254.38 1743.94 1.05021e+07 48661.9 1424.76 1.05021e+07 1431.73 1.05021e+07 828335 1.17724e+06 8.15602e+06 3.21255e+07
74624 20230817.9 39223.9 2.72794e+07 0.828404 87000.2 43536.3 47377.6 53215.2 20060.3 1.88908e+07 4528.3 20270.8 1.25993e+07 12247.3 22575.7 1.67936e+07 12910.7 4489.92 1727.8 1.25993e+07 3513.89 6675.19 1.67936e+07 6506.8 6.30784e+06 3325.09 1750.67 1.05021e+07 47082.1 1427.68 1.05021e+07 1433.62 1.05021e+07 834414 1.18139e+06 8.16148e+06 3.08434e+07

images

@achamayou achamayou changed the title Try to debug SNP CI Fix SNP CI authentication Aug 16, 2023
@achamayou achamayou marked this pull request as ready for review August 17, 2023 08:46
@achamayou achamayou requested a review from a team as a code owner August 17, 2023 08:46
@jumaffre jumaffre added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Aug 17, 2023
@achamayou achamayou merged commit d8bdc3c into microsoft:main Aug 17, 2023
26 of 33 checks passed
@ccf-bot
Copy link
Collaborator

ccf-bot commented Aug 17, 2023

💔 All backports failed

Status Branch Result
release/4.x Backport failed because of merge conflicts

You might need to backport the following PRs to release/4.x:
- Remove graphviz from llvm task (#5551)

Manual backport

To create the backport manually run:

backport --pr 5552

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

achamayou added a commit to achamayou/CCF that referenced this pull request Aug 18, 2023
(cherry picked from commit d8bdc3c)

# Conflicts:
#	.azure-pipelines-templates/deploy_aci.yml
#	scripts/azure_deployment/arm_aci.py
#	tests/code_update.py
@achamayou achamayou added the backported This PR was successfully backported to LTS branch label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNP CI fails to deploy container
4 participants