Do not compare types, use isinstance()

[eddyashton]

Another ruff update, now flagging this in all format check runs.

[ccf-bot]

more_isinstance@74702 aka 20230818.9 vs main ewma over 20 builds from 74291 to 74696

Click to see table

main

build_id	build_number	Commit latency factor	ls_virtual_cft^	pi_ls_virtual_cft^	pi_basic_virtual_cft^	pi_basic_js_virtual_cft^	pi_basic_mt_virtual_cft^	ls_jwt_virtual_cft^	pi_ls_jwt_virtual_cft^	ls_js_virtual_cft^	ls_full_js_virtual_cft^	ls_js_jwt_virtual_cft^	hist_sgx_cft^	pi_basic_mt_sgx_cft^	pi_basic_mt_sgx_cft_mem	ls_sgx_cft^	ls_sgx_cft_mem	pi_ls_sgx_cft^	pi_ls_sgx_cft_mem	pi_basic_sgx_cft^	pi_basic_sgx_cft_mem	pi_basic_js_sgx_cft^	pi_basic_js_sgx_cft_mem	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	pi_ls_jwt_sgx_cft^	pi_ls_jwt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^
74291	20230810.18	0.821145	45729.3	48220.7	54045.9	4527.7	74682.1	12318.8	13038.3	4430.26	3545.51	3380.55	50616.1	36102.1	2.72794e+07	19934.4	1.88908e+07	20116	1.25993e+07	22221.4	1.67936e+07	1729	1.25993e+07	6368.12	1.67936e+07	6484.6	6.30784e+06	1746.12	1.05021e+07	1439.84	1.05021e+07	1426.05	1.05021e+07	836343	1.17805e+06	8.15264e+06	2.98904e+07
74354	20230810.33	0.812767	45640	47642.4	53935.3	4517.2	61954.9	12379.8	13370.8	4450.43	3571.44	3345.81	46737.5	38639.9	2.72794e+07	19946.2	1.88908e+07	20162.1	1.25993e+07	22112.1	1.67936e+07	1725.6	1.25993e+07	6689.93	1.67936e+07	6609.9	6.30784e+06	1744.63	1.05021e+07	1435.11	1.05021e+07	1428.85	1.05021e+07	830213	1.17571e+06	8.14674e+06	3.0835e+07
74367	20230811.2	0.803956	45566.8	47760.7	53872	4526.9	62845.8	12337.1	13317	4412.68	3478.6	3372.57	42185.9	38103	2.72794e+07	19852.6	1.88908e+07	20096.7	1.25993e+07	21937.4	1.67936e+07	1724.1	1.25993e+07	6352.84	1.67936e+07	6514	6.30784e+06	1751.81	1.05021e+07	1433.12	1.05021e+07	1437.58	1.05021e+07	825048	1.16931e+06	8.1553e+06	3.06743e+07
74378	20230811.7	0.802305	45677.6	48432.2	54684.7	4539.7	88492.2	12416.2	13091.7	4453.32	3563.15	3344.07	42180.8	38650.5	2.72794e+07	19903.3	1.88908e+07	20171.7	1.25993e+07	22216.7	1.67936e+07	1719.9	1.25993e+07	6370.76	1.67936e+07	6518.5	6.30784e+06	1745.05	1.05021e+07	1438.55	1.05021e+07	1430.81	1.05021e+07	834643	1.18197e+06	8.15296e+06	3.11369e+07
74393	20230811.11	0.802048	45663.8	47632.7	53582.1	4489.6	72880.2	12392.7	13312.2	4458.86	3496.9	3288.31	47361.6	38890.9	2.51822e+07	20033.6	1.88908e+07	20189.8	1.25993e+07	22213.1	1.67936e+07	1724.7	1.25993e+07	6358.91	1.67936e+07	6522.4	6.30784e+06	1745.64	1.05021e+07	1439.43	1.05021e+07	1423.98	1.05021e+07	829334	1.1786e+06	8.15455e+06	3.08582e+07
74405	20230811.13	0.799883	45739.8	44854.1	53826.6	4505.2	84875.2	12458.7	12889.8	4433.17	3576.83	3264.12	43371.9	38804.4	2.72794e+07	19943.4	1.67936e+07	20158.2	1.05021e+07	22107.1	1.67936e+07	1727.4	1.25993e+07	6692.16	1.67936e+07	6591.3	6.30784e+06	1746.31	1.05021e+07	1427.77	1.05021e+07	1425.5	1.05021e+07	835000	1.17701e+06	8.15566e+06	3.09029e+07
74425	20230814.4	0.788539	43766.9	47791.6	53044.4	4476.8	81005.3	12324.6	12860.2	4480.33	3439.84	3305.9	45672.3	38492.4	2.72794e+07	20058.5	1.88908e+07	20066.3	1.25993e+07	22245.3	1.67936e+07	1728.7	1.05021e+07	6397.71	1.67936e+07	6613.1	6.30784e+06	1742.48	1.05021e+07	1439.23	1.05021e+07	1431.17	1.05021e+07	838021	1.1778e+06	8.15507e+06	3.0784e+07
74432	20230814.7	0.817276	45886.5	47469.4	53530.9	4520.6	75646	12327.4	12921.6	4425.4	3477.25	3266.76	48165.2	38424	2.72794e+07	19999.3	1.88908e+07	20133.7	1.25993e+07	22073.4	1.67936e+07	1717.3	1.25993e+07	6341.62	1.67936e+07	6462	6.30784e+06	1744.92	1.05021e+07	1422.1	1.05021e+07	1425.52	1.05021e+07	825462	1.1799e+06	8.13835e+06	3.08137e+07
74454	20230815.3	0.801873	43713.4	48179.3	53480.5	4445.3	69841.3	12483.5	12750.5	4457.26	3500.77	3263.54	45794.6	38576.9	2.72794e+07	19840.7	1.88908e+07	20095.1	1.25993e+07	22097.1	1.67936e+07	1725.2	1.25993e+07	6340.93	1.67936e+07	6641.6	6.30784e+06	1744.28	1.05021e+07	1439.26	1.05021e+07	1426.85	1.05021e+07	829402	1.18158e+06	8.15537e+06	3.11412e+07
74461	20230815.7	0.818769	46047.3	46914.7	53628.8	4533.4	67371.9	12304.9	12896.9	4441.12	3574.64	3250.43	45998.4	39100.5	2.72794e+07	19972	1.88908e+07	20170.6	1.05021e+07	22108.7	1.67936e+07	1714.7	1.25993e+07	6341.63	1.67936e+07	6474.1	6.30784e+06	1738.21	1.05021e+07	1437.82	1.05021e+07	1432.91	1.05021e+07	828701	1.18254e+06	8.15137e+06	3.22662e+07
74474	20230815.11	0.794527	44006.6	48130.1	53133.7	4482.8	83323.4	12321.3	13339.6	4444.74	3467.96	3266.21	46193.8	38642	2.72794e+07	20045.8	1.88908e+07	20128.8	1.25993e+07	22175.6	1.67936e+07	1735.7	1.25993e+07	6383.4	1.67936e+07	6568.6	6.30784e+06	1742.1	1.05021e+07	1434.21	1.05021e+07	1422.91	1.05021e+07	835648	1.17698e+06	8.1401e+06	3.08666e+07
74510	20230816.1	0.79391	45664.3	48310.3	53485.5	4469.4	70797.5	12494.1	13111.7	4466.5	3466.26	3270.1	42854.4	37360.1	2.72794e+07	19985.7	1.88908e+07	20090.3	1.25993e+07	22138	1.67936e+07	1735.4	1.25993e+07	6719.14	1.67936e+07	6508	6.30784e+06	1746.42	1.05021e+07	1440.41	1.05021e+07	1433.43	1.05021e+07	839230	1.17803e+06	8.15309e+06	3.08174e+07
74553	20230816.14	0.80085	45971.2	48460.4	54174.5	4517.1	83052.6	12271.3	12986.3	4431.14	3571.73	3377.06	48418.1	38976.8	2.72794e+07	20103.4	1.88908e+07	20279.8	1.25993e+07	22556.1	1.67936e+07	1724.4	1.25993e+07	6672.96	1.67936e+07	6484.6	6.30784e+06	1745.01	1.05021e+07	1436.22	1.05021e+07	1429.13	1.05021e+07	822826	1.18085e+06	8.17235e+06	3.06568e+07
74583	20230816.21	0.793694	45640.7	48315.5	53242.5	4534.9	78106.8	12304.8	13098.3	4454.98	3477.94	3266.07	44499	38778.8	2.72794e+07	20066.9	1.88908e+07	20261.6	1.25993e+07	22514.4	1.67936e+07	1731.6	1.25993e+07	6403.27	1.67936e+07	6531.2	6.30784e+06	1742.57	1.05021e+07	1434.72	1.05021e+07	1428.25	1.05021e+07	828489	1.17797e+06	8.15426e+06	3.09478e+07
74600	20230817.1	0.783219	45662.1	48214.4	54245.6	4547	77267.9	12340.4	12920.2	4434.02	3464.06	3356.34	44612.6	38876.7	2.72794e+07	20052.3	1.88908e+07	20283.5	1.25993e+07	22580.6	1.67936e+07	1724.6	1.25993e+07	6363.23	1.67936e+07	6605.3	6.30784e+06	1745.31	1.05021e+07	1436.91	1.05021e+07	1433.67	1.05021e+07	828627	1.18077e+06	8.14194e+06	2.96756e+07
74613	20230817.6	0.804638	43498.7	47884.5	52987.8	4526.1	89897.4	12431.7	13008.1	4483.36	3511.6	3275.81	43634.7	39514.1	2.72794e+07	20086.4	1.88908e+07	20320.4	1.25993e+07	22695.3	1.67936e+07	1734.4	1.05021e+07	6357.59	1.67936e+07	6523.1	6.30784e+06	1742.34	1.05021e+07	1433.89	1.05021e+07	1432.2	1.05021e+07	837791	1.17873e+06	8.1704e+06	3.07212e+07
74628	20230817.10	0.804241	43703.7	47852.8	54250.1	4533.3	84593.9	12319.6	13195.9	4433.68	3403.1	3347.29	46070.2	39524.6	2.72794e+07	19948.9	1.88908e+07	20320.3	1.25993e+07	22656.4	1.67936e+07	1717.1	1.25993e+07	6323.05	1.67936e+07	6538.3	6.30784e+06	1743.34	1.05021e+07	1440.57	1.05021e+07	1413.38	1.05021e+07	838189	1.176e+06	8.1567e+06	3.06614e+07
74674	20230817.23	0.793168	45649.4	48487	55041.7	4548.5	68973.5	12257.5	13105	4481.9	3497.61	3285.09	49469.7	39396.9	2.72794e+07	20028.2	1.88908e+07	20264.3	1.25993e+07	22663.8	1.46964e+07	1710	1.25993e+07	6453.63	1.67936e+07	6430.3	6.30784e+06	1738.07	1.05021e+07	1421.81	1.05021e+07	1419.34	1.05021e+07	830896	1.18034e+06	8.15335e+06	3.08002e+07
74680	20230818.1	0.796933	45447	47821.3	53858.8	4548.6	82628.2	12244	13165.3	4446.82	3505.04	3306.89	50421.1	38842.3	2.72794e+07	20056.2	1.88908e+07	20230.6	1.25993e+07	22652.6	1.67936e+07	1731.5	1.05021e+07	6685.01	1.67936e+07	6564.6	6.30784e+06	1744	1.05021e+07	1441.14	1.05021e+07	1435.45	1.05021e+07	831488	1.17972e+06	8.17102e+06	3.07628e+07
74696	20230818.8	0.765015	45722.7	48148.2	54660.7	4521.3	72111.4	12314.9	12457.6	4425.84	3574.1	3257.92	46232.2	39264.2	2.72794e+07	20021.1	1.88908e+07	20301.4	1.25993e+07	22666.8	1.67936e+07	1744.6	1.25993e+07	6720.95	1.67936e+07	6562.8	6.30784e+06	1740.93	1.05021e+07	1438.6	1.05021e+07	1428.66	1.05021e+07	833383	1.17352e+06	8.13706e+06	3.0809e+07

more_isinstance

build_id	build_number	Commit latency factor	ls_virtual_cft^	pi_ls_virtual_cft^	pi_basic_virtual_cft^	pi_basic_js_virtual_cft^	ls_jwt_virtual_cft^	pi_ls_jwt_virtual_cft^	ls_js_virtual_cft^	ls_full_js_virtual_cft^	ls_js_jwt_virtual_cft^	pi_basic_mt_virtual_cft^	hist_sgx_cft^	ls_sgx_cft^	ls_sgx_cft_mem	pi_ls_sgx_cft^	pi_ls_sgx_cft_mem	pi_basic_sgx_cft^	pi_basic_sgx_cft_mem	pi_basic_js_sgx_cft^	pi_basic_js_sgx_cft_mem	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	pi_ls_jwt_sgx_cft^	pi_ls_jwt_sgx_cft_mem	pi_basic_mt_sgx_cft^	pi_basic_mt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^
74695	20230818.7	0.789417	45577.1	47720.4	54570.8	4551.9	12369.4	13270	4468.43	3579.87	3266.43	76822.1	45012.9	20051.8	1.88908e+07	20183.5	1.25993e+07	22631.6	1.46964e+07	1726.3	1.25993e+07	6370.74	1.67936e+07	6592.7	6.30784e+06	39367.1	2.72794e+07	1745.99	1.05021e+07	1436.03	1.05021e+07	1431.8	1.05021e+07	834346	1.18025e+06	8.15569e+06	3.05457e+07
74702	20230818.9	0.807386	45615.3	48580.7	54248	4523.7	12858.2	12876.6	4423.38	3461.29	3353.65	73220.3	46842.4	20040.4	1.88908e+07	20274.7	1.25993e+07	22615.3	1.46964e+07	1733.7	1.05021e+07	6310.55	1.67936e+07	6477.1	6.30784e+06	39064.4	2.72794e+07	1742.11	1.05021e+07	1436.35	1.05021e+07	1427.75	1.05021e+07	829604	1.181e+06	8.1674e+06	3.08276e+07

[ccf-bot]

💔 Some backports could not be created

Status	Branch	Result
❌	release/3.x	Backport failed because of merge conflicts
✅	release/4.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 5566

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[eddyashton]

💔 All backports failed

Status	Branch	Result
❌	release/3.x	An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 5566

Questions ?

Please refer to the Backport tool documentation

[eddyashton]

Removed 3.x backport - the offending code doesn't exist on that branch, so no backport is necessary.